From: Herbert Xu <herbert@gondor.apana.org.au>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: LKP <lkp@01.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [rhashtable] [ INFO: suspicious RCU usage. ]
Date: Thu, 2 Apr 2015 11:58:10 +0800 [thread overview]
Message-ID: <20150402035810.GA5408@gondor.apana.org.au> (raw)
In-Reply-To: <20150402005211.GC12979@wfg-t540p.sh.intel.com>
On Thu, Apr 02, 2015 at 08:52:11AM +0800, Fengguang Wu wrote:
> Hi Herbert,
>
> 0day kernel testing robot got the below dmesg and the first bad commit is
>
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>
> commit ccd57b1bd32460d27bbb9c599e795628a3c66983
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> AuthorDate: Tue Mar 24 00:50:28 2015 +1100
> Commit: David S. Miller <davem@davemloft.net>
> CommitDate: Mon Mar 23 22:07:52 2015 -0400
>
> rhashtable: Add immediate rehash during insertion
>
> This patch reintroduces immediate rehash during insertion. If
> we find during insertion that the table is full or the chain
> length exceeds a set limit (currently 16 but may be disabled
> with insecure_elasticity) then we will force an immediate rehash.
> The rehash will contain an expansion if the table utilisation
> exceeds 75%.
>
> If this rehash fails then the insertion will fail. Otherwise the
> insertion will be reattempted in the new hash table.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> Acked-by: Thomas Graf <tgraf@suug.ch>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> [ 0.552992] Adding 2048 keys
> [ 0.553792]
> [ 0.554400] ===============================
> [ 0.555285] [ INFO: suspicious RCU usage. ]
> [ 0.556176] 4.0.0-rc4-01225-gccd57b1 #171 Not tainted
> [ 0.557156] -------------------------------
> [ 0.558044] lib/rhashtable.c:400 suspicious rcu_dereference_check() usage!
This should have been fixed by
58be8a583d8d316448bafa5926414cfb83c02dec.
Can you check whether this commit was in your tested tree?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-04-02 3:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 0:52 [rhashtable] [ INFO: suspicious RCU usage. ] Fengguang Wu
2015-04-02 3:58 ` Herbert Xu [this message]
2015-04-02 4:11 ` Fengguang Wu
2015-04-02 4:29 ` Herbert Xu
2015-04-02 7:33 ` Thomas Graf
2015-04-03 19:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402035810.GA5408@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox