From: David Miller <davem@davemloft.net>
To: ipm@chirality.org.uk
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] ipv4: coding style - comparisons with NULL
Date: Fri, 03 Apr 2015 12:11:38 -0400 (EDT) [thread overview]
Message-ID: <20150403.121138.1140806036726597601.davem@davemloft.net> (raw)
In-Reply-To: <1428049047-14783-1-git-send-email-ipm@chirality.org.uk>
From: Ian Morris <ipm@chirality.org.uk>
Date: Fri, 3 Apr 2015 09:17:25 +0100
> Per the suggestion of Joe Perches, attached is a patch which aligns the
> coding style in ipv4 for comparisons with NULL.
>
> The code uses multiple different styles when comparing with NULL (I.e.
> x == NULL and !x as well as x != NULL and x). Generally the latter form
> is preferred in netdev and so this changes aligns the code to this style.
Series applied, thanks.
prev parent reply other threads:[~2015-04-03 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 8:17 [PATCH net-next 0/2] ipv4: coding style - comparisons with NULL Ian Morris
2015-04-03 8:17 ` [PATCH net-next 1/2] ipv4: coding style: comparison for equality " Ian Morris
2015-04-03 16:51 ` Joe Perches
2015-04-03 8:17 ` [PATCH net-next 2/2] ipv4: coding style: comparison for inequality " Ian Morris
2015-04-03 16:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403.121138.1140806036726597601.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ipm@chirality.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).