public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: herbert@gondor.apana.org.au, fengguang.wu@intel.com, lkp@01.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [rhashtable] [ INFO: suspicious RCU usage. ]
Date: Fri, 03 Apr 2015 15:09:51 -0400 (EDT)	[thread overview]
Message-ID: <20150403.150951.1949065951005722940.davem@davemloft.net> (raw)
In-Reply-To: <20150402073356.GC19425@casper.infradead.org>

From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 2 Apr 2015 08:33:56 +0100

> On 04/02/15 at 12:29pm, Herbert Xu wrote:
>> On Thu, Apr 02, 2015 at 12:11:35PM +0800, Fengguang Wu wrote:
>> > 
>> > Yes it is contained in next-20150401 which is bad:
>> > 
>> > # extra tests on tree/branch next/master
>> > git bisect  bad e954104e2b634b42811dad8d502cbf240f206df2  # 21:22      0-     60  Add linux-next specific files for 20150401
>> > 
>> > The dmesg there is
>> > 
>> > [    1.149409] test_firmware: interface ready
>> > [    1.150293] Running resizable hashtable tests...
>> > [    1.151209]   Adding 2048 keys
>> > [    1.152069] ------------[ cut here ]------------
>> > [    1.152978] WARNING: CPU: 0 PID: 1 at lib/rhashtable.c:409 rhashtable_insert_rehash+0x9d/0x1d0()
>> 
>> I see.  This is actually a completely different problem.
>> 
>> ---8<---
>> test_rhashtable: Remove bogus max_size setting
>> 
>> Now that resizing is completely automatic, we need to remove
>> the max_size setting or the test will fail.
>> 
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> Acked-by: Thomas Graf <tgraf@suug.ch>
> 
> Had the same fix queued up in an upcoming series ;-)

Applied to net-next, thanks everyone.

      reply	other threads:[~2015-04-03 19:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02  0:52 [rhashtable] [ INFO: suspicious RCU usage. ] Fengguang Wu
2015-04-02  3:58 ` Herbert Xu
2015-04-02  4:11   ` Fengguang Wu
2015-04-02  4:29     ` Herbert Xu
2015-04-02  7:33       ` Thomas Graf
2015-04-03 19:09         ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150403.150951.1949065951005722940.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fengguang.wu@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox