netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fou: Don't use const __read_mostly
@ 2015-04-08 13:04 Andi Kleen
  2015-04-08 19:29 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2015-04-08 13:04 UTC (permalink / raw)
  To: netdev; +Cc: therbert, Andi Kleen

From: Andi Kleen <ak@linux.intel.com>

const __read_mostly is a senseless combination. If something
is already const it cannot be __read_mostly. Remove the bogus
__read_mostly in the fou driver.

This fixes section conflicts with LTO.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 net/ipv4/fou.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
index ff069f6..335e752 100644
--- a/net/ipv4/fou.c
+++ b/net/ipv4/fou.c
@@ -771,12 +771,12 @@ EXPORT_SYMBOL(gue_build_header);
 
 #ifdef CONFIG_NET_FOU_IP_TUNNELS
 
-static const struct ip_tunnel_encap_ops __read_mostly fou_iptun_ops = {
+static const struct ip_tunnel_encap_ops fou_iptun_ops = {
 	.encap_hlen = fou_encap_hlen,
 	.build_header = fou_build_header,
 };
 
-static const struct ip_tunnel_encap_ops __read_mostly gue_iptun_ops = {
+static const struct ip_tunnel_encap_ops gue_iptun_ops = {
 	.encap_hlen = gue_encap_hlen,
 	.build_header = gue_build_header,
 };
-- 
2.3.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fou: Don't use const __read_mostly
  2015-04-08 13:04 [PATCH] fou: Don't use const __read_mostly Andi Kleen
@ 2015-04-08 19:29 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-04-08 19:29 UTC (permalink / raw)
  To: andi; +Cc: netdev, therbert, ak

From: Andi Kleen <andi@firstfloor.org>
Date: Wed,  8 Apr 2015 06:04:31 -0700

> From: Andi Kleen <ak@linux.intel.com>
> 
> const __read_mostly is a senseless combination. If something
> is already const it cannot be __read_mostly. Remove the bogus
> __read_mostly in the fou driver.
> 
> This fixes section conflicts with LTO.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-08 19:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-08 13:04 [PATCH] fou: Don't use const __read_mostly Andi Kleen
2015-04-08 19:29 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).