From: Alan <gnomes@lxorguk.ukuu.org.uk>
To: netdev@vger.kernel.org, trivial@kernel.org
Subject: [PATCH] ppp_synctty: remove unneeded NULL check
Date: Wed, 08 Apr 2015 13:58:15 +0100 [thread overview]
Message-ID: <20150408125807.30123.91282.stgit@localhost.localdomain> (raw)
Fix a random whine found by coverity. Had it been NULL it would have
showered us with oopses long before.
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
0 files changed
diff --git a/drivers/net/ppp/ppp_synctty.c b/drivers/net/ppp/ppp_synctty.c
index 925d3e2..b5592b8 100644
--- a/drivers/net/ppp/ppp_synctty.c
+++ b/drivers/net/ppp/ppp_synctty.c
@@ -549,7 +549,7 @@ ppp_sync_txmunge(struct syncppp *ap, struct sk_buff *skb)
ap->last_xmit = jiffies;
- if (skb && ap->flags & SC_LOG_OUTPKT)
+ if (ap->flags & SC_LOG_OUTPKT)
ppp_print_buffer ("send buffer", skb->data, skb->len);
return skb;
reply other threads:[~2015-04-08 12:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408125807.30123.91282.stgit@localhost.localdomain \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=netdev@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox