From: Thomas Graf <tgraf@suug.ch>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Jiri Pirko <jiri@resnulli.us>,
Alexei Starovoitov <ast@plumgrid.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 2/2] tc: make ingress and egress qdiscs consistent
Date: Wed, 8 Apr 2015 14:14:17 +0100 [thread overview]
Message-ID: <20150408131417.GA28656@casper.infradead.org> (raw)
In-Reply-To: <55252611.3040109@mojatatu.com>
On 04/08/15 at 08:58am, Jamal Hadi Salim wrote:
> On 04/08/15 08:31, Daniel Borkmann wrote:
> >That means the tc's cls_u32
> >sample selectors a la ip, ip6, udp, tcp, icmp don't work on ingress
> >either,so in u32 speak you would need to do that by hand, but that
> >doesn't work as you don't have the Ethernet type context available.
> >Am I missing something? :)
>
> u32 works fine. I am sure i have tests which run these on both
> in/egress.
His point is that an u32 filter written for egress won't work at
ingress because the offsets are different. This has always been the
case and we can't break this behaviour either. I'm sure you have
these weird negative offset u32 egress filters in your repertoire
as well ;-)
Even if we made ingress offsets start at the network header we
would still have to make this depend on a flag which new users have
to set.
next prev parent reply other threads:[~2015-04-08 13:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 1:03 [PATCH v2 net-next 1/2] net: introduce skb_postpush_rcsum() helper Alexei Starovoitov
2015-04-08 1:03 ` [PATCH v2 net-next 2/2] tc: make ingress and egress qdiscs consistent Alexei Starovoitov
2015-04-08 2:35 ` David Miller
2015-04-08 3:22 ` Alexei Starovoitov
2015-04-08 4:48 ` Alexei Starovoitov
2015-04-08 8:36 ` Daniel Borkmann
2015-04-08 9:05 ` Jiri Pirko
2015-04-08 10:54 ` Daniel Borkmann
2015-04-08 11:14 ` Daniel Borkmann
2015-04-08 11:47 ` Jamal Hadi Salim
2015-04-08 12:31 ` Daniel Borkmann
2015-04-08 12:58 ` Jamal Hadi Salim
2015-04-08 13:14 ` Thomas Graf [this message]
2015-04-08 13:27 ` Daniel Borkmann
2015-04-08 13:34 ` Jiri Pirko
2015-04-08 13:41 ` Daniel Borkmann
2015-04-08 13:47 ` Thomas Graf
2015-04-08 13:52 ` Jamal Hadi Salim
2015-04-08 14:53 ` Daniel Borkmann
2015-04-08 16:26 ` Alexei Starovoitov
2015-04-08 16:32 ` David Miller
2015-04-08 16:44 ` Alexei Starovoitov
2015-04-08 16:54 ` Daniel Borkmann
2015-04-08 11:43 ` Jamal Hadi Salim
2015-04-08 7:25 ` [PATCH v2 net-next 1/2] net: introduce skb_postpush_rcsum() helper Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408131417.GA28656@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).