From: David Miller <davem@davemloft.net>
To: jesse@nicira.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] udptunnels: Call handle_offloads after inserting vlan tag.
Date: Thu, 09 Apr 2015 14:57:09 -0400 (EDT) [thread overview]
Message-ID: <20150409.145709.1076905748131956555.davem@davemloft.net> (raw)
In-Reply-To: <1428603554-62449-1-git-send-email-jesse@nicira.com>
From: Jesse Gross <jesse@nicira.com>
Date: Thu, 9 Apr 2015 11:19:14 -0700
> handle_offloads() calls skb_reset_inner_headers() to store
> the layer pointers to the encapsulated packet. However, we
> currently push the vlag tag (if there is one) onto the packet
> afterwards. This changes the MAC header for the encapsulated
> packet but it is not reflected in skb->inner_mac_header, which
> breaks GSO and drivers which attempt to use this for encapsulation
> offloads.
>
> Fixes: 1eaa8178 ("vxlan: Add tx-vlan offload support.")
> Signed-off-by: Jesse Gross <jesse@nicira.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2015-04-09 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 18:19 [PATCH net] udptunnels: Call handle_offloads after inserting vlan tag Jesse Gross
2015-04-09 18:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409.145709.1076905748131956555.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).