netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.h.duyck@redhat.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: [net-next PATCH 0/4] Replace wmb()/rmb() with dma_wmb()/dma_rmb() where appropriate, round 2
Date: Wed, 08 Apr 2015 18:49:23 -0700	[thread overview]
Message-ID: <20150409014001.4434.85280.stgit@ahduyck-vm-fedora22> (raw)

More cleanup of drivers in order to start making use of dma_rmb and dma_wmb
calls.  This is another pass of what I would consider to be low hanging
fruit.  There may be other opportunities to make use of the barriers in the
Mellanox and Chelsio drivers but I didn't want to risk meddling with code I
was not completely familiar with so I am leaving that for future work.

I have revisited the Mellanox driver changes.  This time around I went only
for the sections with a clearly defined pattern.  For dma_wmb I used it
between accesses of the descriptor bits followed by owner or size.  For
dma_wmb I used it to replace rmb following a read of the ownership bit in
the descriptor.

---

Alexander Duyck (4):
      cxgb3/4/4vf: Update drivers to use dma_rmb/wmb where appropriate
      mlx4/mlx5: Use dma_wmb/rmb where appropriate
      i40e/i40evf: Use dma_rmb where appropriate
      e100: Use dma_rmb/wmb where appropriate


 drivers/net/ethernet/chelsio/cxgb3/sge.c      |   20 ++++++++++----------
 drivers/net/ethernet/chelsio/cxgb4/sge.c      |    4 ++--
 drivers/net/ethernet/chelsio/cxgb4vf/sge.c    |    4 ++--
 drivers/net/ethernet/intel/e100.c             |    6 +++---
 drivers/net/ethernet/intel/i40e/i40e_txrx.c   |    4 ++--
 drivers/net/ethernet/intel/i40evf/i40e_txrx.c |    4 ++--
 drivers/net/ethernet/mellanox/mlx4/en_rx.c    |    2 +-
 drivers/net/ethernet/mellanox/mlx4/en_tx.c    |   12 ++++++------
 drivers/net/ethernet/mellanox/mlx4/eq.c       |    4 ++--
 drivers/net/ethernet/mellanox/mlx5/core/eq.c  |    2 +-
 10 files changed, 31 insertions(+), 31 deletions(-)

--

             reply	other threads:[~2015-04-09  1:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09  1:49 Alexander Duyck [this message]
2015-04-09  1:49 ` [net-next PATCH 1/4] cxgb3/4/4vf: Update drivers to use dma_rmb/wmb where appropriate Alexander Duyck
2015-04-09  1:49 ` [net-next PATCH 2/4] mlx4/mlx5: Use dma_wmb/rmb " Alexander Duyck
2015-04-09  1:49 ` [net-next PATCH 3/4] i40e/i40evf: Use dma_rmb " Alexander Duyck
2015-04-09  2:52   ` Jeff Kirsher
2015-04-09  1:49 ` [net-next PATCH 4/4] e100: Use dma_rmb/wmb " Alexander Duyck
2015-04-09  2:48   ` Jeff Kirsher
2015-04-09  2:36 ` [net-next PATCH 0/4] Replace wmb()/rmb() with dma_wmb()/dma_rmb() where appropriate, round 2 David Miller
2015-04-09  2:46   ` Alexander Duyck
2015-04-09 18:32 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409014001.4434.85280.stgit@ahduyck-vm-fedora22 \
    --to=alexander.h.duyck@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).