From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org, Vadim Kochan <vadim4j@gmail.com>
Subject: Re: [PATCH iproute2] configure: add missing INCLUDE to netnsid detection
Date: Fri, 10 Apr 2015 13:25:13 -0700 [thread overview]
Message-ID: <20150410132513.6a8f20fa@urahara> (raw)
In-Reply-To: <42d42073b18a4cc0aebbc912fcc14788693c0c75.1428522001.git.jbenc@redhat.com>
On Wed, 8 Apr 2015 21:42:00 +0200
Jiri Benc <jbenc@redhat.com> wrote:
> Fixes: d116ff34145b0 ("ip netns: Fix rtnl error while print netns list")
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
> ---
> The whole check added by d116ff34145b0 is dubious, though. This should be
> a run time check, not a compile time one.
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 631938e97206..e54f4b6db5e8 100755
> --- a/configure
> +++ b/configure
> @@ -224,7 +224,7 @@ check_netnsid()
> #include <linux/rtnetlink.h>
> int test_def = RTM_GETNSID;
> EOF
> - $CC -c $TMPDIR/netnsid.c >/dev/null 2>&1
> + $CC -I$INCLUDE -c $TMPDIR/netnsid.c >/dev/null 2>&1
> if [ $? -eq 0 ]
> then
> echo "IP_CONFIG_NETNSID:=y" >> Config
Merged, but always up for a better solution in future.
prev parent reply other threads:[~2015-04-10 20:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 19:42 [PATCH iproute2] configure: add missing INCLUDE to netnsid detection Jiri Benc
2015-04-08 19:40 ` Vadim Kochan
2015-04-10 16:17 ` Nicolas Dichtel
2015-04-13 8:23 ` [PATCH iproute2 1/3] Revert "configure: add missing INCLUDE to netnsid detection" Nicolas Dichtel
2015-04-13 8:23 ` [PATCH iproute2 2/3] Revert "ip netns: Fix rtnl error while print netns list" Nicolas Dichtel
2015-04-13 8:23 ` [PATCH iproute2 3/3] ipnetns: add a runtime check for RTM_GETNSID support Nicolas Dichtel
2015-04-13 8:34 ` [PATCH v2 iproute2 1/3] Revert "configure: add missing INCLUDE to netnsid detection" Nicolas Dichtel
2015-04-13 8:34 ` [PATCH v2 iproute2 2/3] Revert "ip netns: Fix rtnl error while print netns list" Nicolas Dichtel
2015-04-13 8:34 ` [PATCH v2 iproute2 3/3] ipnetns: add a runtime check for RTM_GETNSID support Nicolas Dichtel
[not found] ` <f5aa0068662f470e988a01e3b92450f1@HQ1WP-EXMB12.corp.brocade.com>
2015-04-13 15:53 ` [PATCH " Stephen Hemminger
2015-04-10 20:25 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410132513.6a8f20fa@urahara \
--to=stephen@networkplumber.org \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox