From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: sfeldma@gmail.com, netdev@vger.kernel.org,
roopa@cumulusnetworks.com, f.fainelli@gmail.com,
gospo@cumulusnetworks.com
Subject: Re: [patch net-next 1/2] switchdev: s/netdev_switch_/switchdev_/
Date: Mon, 13 Apr 2015 13:24:38 -0400 (EDT) [thread overview]
Message-ID: <20150413.132438.259409084264003362.davem@davemloft.net> (raw)
In-Reply-To: <20150413151932.GH2090@nanopsycho.lan>
From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 13 Apr 2015 17:19:32 +0200
> Mon, Apr 13, 2015 at 05:06:04PM CEST, sfeldma@gmail.com wrote:
>>On Mon, Apr 13, 2015 at 8:01 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>> Mon, Apr 13, 2015 at 04:48:51PM CEST, sfeldma@gmail.com wrote:
>>>>On Mon, Apr 13, 2015 at 7:14 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>>>> Turned out that "switchdev" sticks. So just unify all releated terms to
>>>>> use this prefix.
>>>>>
>>>>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>>>>
>>>>NACK. I'm right in the middle of a large patchset which touches all
>>>>of these files in all of those places and a rename before mine will
>>>>create a git merge nightmare. Please wait to post any rename patches
>>>>until after my set goes in.
>>>
>>> Makes sense to me to rename first so you can add new functions with
>>> "switchdev_" prefix on top of that.
>>
>>I am renaming, to swdev_ and all new stuff gets swdev_ prefix. You're
>>welcome to change the prefix after my patch set goes in but don't try
>>to slip it under as it totally messes up my patch stack.
>
> Scott, at least please use "switchdev_" prefix for your new stuff so it
> does not have to be renamed right after.
Scott, I think Jiri's request is reasonable.
next prev parent reply other threads:[~2015-04-13 17:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 14:14 [patch net-next 0/2] switchdev: unify naming prefix Jiri Pirko
2015-04-13 14:14 ` [patch net-next 1/2] switchdev: s/netdev_switch_/switchdev_/ Jiri Pirko
2015-04-13 14:48 ` Scott Feldman
2015-04-13 15:01 ` Jiri Pirko
2015-04-13 15:06 ` Scott Feldman
2015-04-13 15:19 ` Jiri Pirko
2015-04-13 17:24 ` David Miller [this message]
2015-04-13 19:19 ` Jiri Pirko
2015-04-13 20:18 ` David Miller
2015-04-13 19:25 ` Samudrala, Sridhar
2015-04-13 20:00 ` Jiri Pirko
2015-04-13 14:14 ` [patch net-next 2/2] switchdev: s/swdev_/switchdev_/ Jiri Pirko
2015-04-13 17:50 ` [patch net-next 0/2] switchdev: unify naming prefix Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413.132438.259409084264003362.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gospo@cumulusnetworks.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).