From: David Miller <davem@davemloft.net>
To: amirv@mellanox.com
Cc: netdev@vger.kernel.org, yevgenyp@mellanox.com,
saeedm@mellanox.com, ogerlitz@mellanox.com, achiad@mellanox.com,
idos@mellanox.com, talal@mellanox.com
Subject: Re: [PATCH net-next V1 00/11] net/mlx5: ConnectX-4 100G Ethernet driver
Date: Mon, 13 Apr 2015 22:15:22 -0400 (EDT) [thread overview]
Message-ID: <20150413.221522.162480193486167425.davem@davemloft.net> (raw)
In-Reply-To: <1428925501-2373-1-git-send-email-amirv@mellanox.com>
From: Amir Vadai <amirv@mellanox.com>
Date: Mon, 13 Apr 2015 14:44:50 +0300
> - Removed V0 Patch 1/11 ("net/mlx5_core: Virtually extend work/completion queue
> buffers by one page") due to misuse of DMA API. Thanks Dave.
I don't know how stupid you think I am....
You may have removed the patch that did the refactoring, but the
completely broken code misusing the DMA API is still there in this
driver.
I said I want you to fix this fundamental problem with your driver
before making major changes like this series to it.
And I really meant it.
Don't try to side step the issue in the way that you did here.
Thanks.
next prev parent reply other threads:[~2015-04-14 2:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 11:44 [PATCH net-next V1 00/11] net/mlx5: ConnectX-4 100G Ethernet driver Amir Vadai
2015-04-13 11:44 ` [PATCH net-next V1 01/11] net/mlx5_core: Set irq affinity hints Amir Vadai
2015-04-13 11:44 ` [PATCH net-next V1 02/11] net/mlx5_core: Add EQ renaming mechanism Amir Vadai
2015-04-13 11:44 ` [PATCH net-next V1 03/11] net/mlx5_core: HW data structs/types definitions preparation for mlx5 ehternet driver Amir Vadai
2015-04-13 11:44 ` [PATCH net-next V1 04/11] net/mlx5_core/ib: New device capabilities handling Amir Vadai
2015-04-13 11:44 ` [PATCH net-next V1 05/11] net/mlx5_core: Implement get and set functions of ptys register fields Amir Vadai
2015-04-13 11:44 ` [PATCH net-next V1 06/11] net/mlx5_core: Implement get/set port status Amir Vadai
2015-04-13 11:44 ` [PATCH net-next V1 07/11] net/mlx5_core: Modify CQ moderation parameters Amir Vadai
2015-04-13 11:44 ` [PATCH net-next V1 08/11] net/mlx5_core: Set/Query port MTU commands Amir Vadai
2015-04-13 11:44 ` [PATCH net-next V1 09/11] net/mlx5: Ethernet Datapath files Amir Vadai
2015-04-13 11:45 ` [PATCH net-next V1 10/11] net/mlx5: Ethernet resources handling Amir Vadai
2015-04-13 11:45 ` [PATCH net-next V1 11/11] net/mlx5: Ethernet driver Amir Vadai
2015-04-14 2:15 ` David Miller [this message]
2015-04-14 7:05 ` [PATCH net-next V1 00/11] net/mlx5: ConnectX-4 100G " Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413.221522.162480193486167425.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=achiad@mellanox.com \
--cc=amirv@mellanox.com \
--cc=idos@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=talal@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).