From: Thomas Graf <tgraf@suug.ch>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: David Miller <davem@davemloft.net>,
jiri@resnulli.us, netdev@vger.kernel.org, jhs@mojatatu.com,
jesse@nicira.com
Subject: Re: [patch net-next v3] tc: introduce OpenFlow classifier
Date: Mon, 13 Apr 2015 09:26:00 +0100 [thread overview]
Message-ID: <20150413082600.GA16323@casper.infradead.org> (raw)
In-Reply-To: <20150413010342.GA1672@Alexeis-MBP.westell.com>
On 04/12/15 at 06:03pm, Alexei Starovoitov wrote:
> On Sun, Apr 12, 2015 at 08:36:18PM -0400, David Miller wrote:
> >
> > It's easy to parameterize what flow dissector does and share code.
>
> yes. Though I wouldn't pessimize ixgbe rx path even by single
> cycle to accommodate openflow spec. As far as I understand the
> skb_flow_dissect() job from driver point of view is to figure
> out header length for copybreak, which includes parsing encaps,
> whereas openflow stops at outer header. Even with this difference,
> it surely can be parameterized. Would be great to share if it
> doesn't cost rx anything.
A flow dissector that only extracts what's needed would benefit
everyone. I guess static keys could help here as the flow field
selection is definitely a slow path operation.
Even OVS could benefit from this eventually, it would just need
to do a full extract before the key is sent to user space.
Also, the logic to generate the wildcard mask and match on it
should be generalized as well.
next prev parent reply other threads:[~2015-04-13 8:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 12:58 [patch net-next v3] tc: introduce OpenFlow classifier Jiri Pirko
2015-04-09 13:00 ` [patch iproute2 v3] tc: add support for " Jiri Pirko
2015-04-09 21:34 ` [patch net-next v3] tc: introduce " David Miller
2015-04-10 9:12 ` Jiri Pirko
2015-04-10 9:30 ` Daniel Borkmann
2015-04-10 11:46 ` Jiri Pirko
2015-04-10 13:48 ` Jamal Hadi Salim
2015-04-10 10:03 ` Thomas Graf
2015-04-10 12:23 ` David Miller
2015-04-10 12:45 ` Jiri Pirko
2015-04-11 16:12 ` Alexei Starovoitov
2015-04-12 7:53 ` Jiri Pirko
2015-04-12 23:44 ` David Miller
2015-04-13 0:12 ` Alexei Starovoitov
2015-04-13 0:36 ` David Miller
2015-04-13 1:03 ` Alexei Starovoitov
2015-04-13 8:26 ` Thomas Graf [this message]
2015-04-13 14:34 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413082600.GA16323@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).