netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sebastian.poehn@gmail.com
Cc: stephen@networkplumber.org, netdev@vger.kernel.org, fw@strlen.de,
	eric.dumazet@gmail.com
Subject: Re: [PATCH] ip_forward: Drop frames with attached skb->sk
Date: Tue, 14 Apr 2015 12:50:45 -0400 (EDT)	[thread overview]
Message-ID: <20150414.125045.1736152567665368862.davem@davemloft.net> (raw)
In-Reply-To: <1428992320.6812.20.camel@googlemail.com>

From: Sebastian Poehn <sebastian.poehn@gmail.com>
Date: Tue, 14 Apr 2015 08:18:40 +0200

> On Mon, 2015-04-13 at 23:07 -0700, Stephen Hemminger wrote:
>> On Tue, 14 Apr 2015 07:52:04 +0200
>> Sebastian Poehn <sebastian.poehn@gmail.com> wrote:
>> 
>> >  
>> > +	/* this should happen neither */
>> > +	if (unlikely(skb->sk))
>> > +		goto drop;
>> > +
>> 
>> With gcc, all goto's are already treated as unlikely().
> 
> Thanks for that recommendation. But before I re-cook: What about Clang
> and ICC?

I think even if this is the case with gcc, it's good documentation.

  reply	other threads:[~2015-04-14 16:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14  5:52 [PATCH] ip_forward: Drop frames with attached skb->sk Sebastian Poehn
2015-04-14  6:07 ` Stephen Hemminger
2015-04-14  6:18   ` Sebastian Poehn
2015-04-14 16:50     ` David Miller [this message]
2015-04-14  6:33 ` yzhu1
2015-04-14  6:40   ` Sebastian Poehn
2015-04-14 11:54     ` Eric Dumazet
2015-04-14 18:23       ` David Miller
2015-04-15  7:32         ` Sebastian Poehn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150414.125045.1736152567665368862.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=sebastian.poehn@gmail.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).