From: David Miller <davem@davemloft.net>
To: dvlasenk@redhat.com
Cc: ebiederm@xmission.com, jengelh@medozas.de, jpirko@redhat.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netns: deinline net_generic()
Date: Tue, 14 Apr 2015 14:37:47 -0400 (EDT) [thread overview]
Message-ID: <20150414.143747.1155055158701231768.davem@davemloft.net> (raw)
In-Reply-To: <1429014311-19868-1-git-send-email-dvlasenk@redhat.com>
From: Denys Vlasenko <dvlasenk@redhat.com>
Date: Tue, 14 Apr 2015 14:25:11 +0200
> On x86 allyesconfig build:
> The function compiles to 130 bytes of machine code.
> It has 493 callsites.
> Total reduction of vmlinux size: 27906 bytes.
>
> text data bss dec hex filename
> 82447071 22255384 20627456 125329911 77861f7 vmlinux4
> 82419165 22255384 20627456 125302005 777f4f5 vmlinux5
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
That BUG_ON() was added 7 years ago, and I don't remember it ever
triggering or helping us diagnose something, so just remove it and
keep the function inlined.
next prev parent reply other threads:[~2015-04-14 18:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 12:25 [PATCH] netns: deinline net_generic() Denys Vlasenko
2015-04-14 12:36 ` Jiri Pirko
2015-04-14 13:19 ` Eric Dumazet
2015-04-14 13:57 ` Denys Vlasenko
2015-04-14 14:21 ` Eric Dumazet
2015-04-14 15:04 ` Denys Vlasenko
2015-04-14 15:25 ` Eric Dumazet
2015-04-14 18:37 ` David Miller [this message]
2015-04-16 11:14 ` Denys Vlasenko
2015-04-16 12:38 ` Eric Dumazet
2015-04-17 17:05 ` Denys Vlasenko
2015-04-17 17:42 ` Eric Dumazet
2015-04-17 18:05 ` Denys Vlasenko
2015-04-17 18:55 ` David Miller
2015-04-17 19:55 ` David Miller
2015-04-16 15:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414.143747.1155055158701231768.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dvlasenk@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jengelh@medozas.de \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).