* [Patch net-next] fou: avoid missing unlock in failure path
@ 2015-04-14 16:32 Cong Wang
2015-04-14 17:01 ` Eric Dumazet
2015-04-14 18:42 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Cong Wang @ 2015-04-14 16:32 UTC (permalink / raw)
To: netdev; +Cc: Tom Herbert, Cong Wang, Dan Carpenter
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
net/ipv4/fou.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
index 2637102..1df3399 100644
--- a/net/ipv4/fou.c
+++ b/net/ipv4/fou.c
@@ -711,11 +711,10 @@ static int fou_nl_dump(struct sk_buff *skb, struct netlink_callback *cb)
cb->nlh->nlmsg_seq, NLM_F_MULTI,
skb, FOU_CMD_GET);
if (ret)
- goto done;
+ break;
}
mutex_unlock(&fn->fou_lock);
-done:
cb->args[0] = idx;
return skb->len;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Patch net-next] fou: avoid missing unlock in failure path
2015-04-14 16:32 [Patch net-next] fou: avoid missing unlock in failure path Cong Wang
@ 2015-04-14 17:01 ` Eric Dumazet
2015-04-14 18:25 ` Cong Wang
2015-04-14 18:42 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2015-04-14 17:01 UTC (permalink / raw)
To: Cong Wang; +Cc: netdev, Tom Herbert, Dan Carpenter
On Tue, 2015-04-14 at 09:32 -0700, Cong Wang wrote:
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
> net/ipv4/fou.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
> index 2637102..1df3399 100644
> --- a/net/ipv4/fou.c
> +++ b/net/ipv4/fou.c
> @@ -711,11 +711,10 @@ static int fou_nl_dump(struct sk_buff *skb, struct netlink_callback *cb)
> cb->nlh->nlmsg_seq, NLM_F_MULTI,
> skb, FOU_CMD_GET);
> if (ret)
> - goto done;
> + break;
> }
> mutex_unlock(&fn->fou_lock);
>
> -done:
> cb->args[0] = idx;
> return skb->len;
> }
When was this bug added ?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch net-next] fou: avoid missing unlock in failure path
2015-04-14 16:32 [Patch net-next] fou: avoid missing unlock in failure path Cong Wang
2015-04-14 17:01 ` Eric Dumazet
@ 2015-04-14 18:42 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2015-04-14 18:42 UTC (permalink / raw)
To: xiyou.wangcong; +Cc: netdev, tom, dan.carpenter
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue, 14 Apr 2015 09:32:30 -0700
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
This doesn't apply cleanly to the net-next tree, please resubmit and this will
give you a chance to add the Fixes: tag too.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-14 18:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-14 16:32 [Patch net-next] fou: avoid missing unlock in failure path Cong Wang
2015-04-14 17:01 ` Eric Dumazet
2015-04-14 18:25 ` Cong Wang
2015-04-14 18:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).