From: David Miller <davem@davemloft.net>
To: amirv@mellanox.com
Cc: netdev@vger.kernel.org, yevgenyp@mellanox.com,
saeedm@mellanox.com, ogerlitz@mellanox.com, achiad@mellanox.com,
idos@mellanox.com, talal@mellanox.com
Subject: Re: [PATCH net-next V2 12/12] net/mlx5: Ethernet driver
Date: Tue, 14 Apr 2015 14:51:13 -0400 (EDT) [thread overview]
Message-ID: <20150414.145113.192331451516214119.davem@davemloft.net> (raw)
In-Reply-To: <1428999635-15025-13-git-send-email-amirv@mellanox.com>
From: Amir Vadai <amirv@mellanox.com>
Date: Tue, 14 Apr 2015 11:20:35 +0300
> Signed-off-by: Amir Vadai <amirv@mellanox.com>
What does "Ethernet driver" mean?
Are you adding a new ethernet driver? If so, what is it for and how
does it interact with the existing mlx5 driver?
It looks to me like you are adding a lot of code and objects to the
existing mlx5 module. An incredible amount, in fact. This seems very
suboptimal especially for users of the existing mlx5 chips.
You haven't discussed this, what design decisions made you decide
in the end to do it this way, etc.
You absolutely have to say something other than "Ethernet driver"
in this commit message, I expect several paragraphs of details
and the hows and whys of the change as it is a non-trivial amount
of code being added here.
I still consider this patch series not ready yet, and the merge
window is open thus closing the net-next tree.
You will therefore need to wait until the net-next tree opens
again before submitting this series again.
THanks.
next prev parent reply other threads:[~2015-04-14 18:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 8:20 [PATCH net-next V2 00/12] net/mlx5: ConnectX-4 100G Ethernet driver Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 01/12] net/mlx5_core,mlx5_ib: Do not use vmap() on coherent memory Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 02/12] net/mlx5_core: Set irq affinity hints Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 03/12] net/mlx5_core: Add EQ renaming mechanism Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 04/12] net/mlx5_core: HW data structs/types definitions preparation for mlx5 ehternet driver Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 05/12] net/mlx5_core/ib: New device capabilities handling Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 06/12] net/mlx5_core: Implement get and set functions of ptys register fields Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 07/12] net/mlx5_core: Implement get/set port status Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 08/12] net/mlx5_core: Modify CQ moderation parameters Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 09/12] net/mlx5_core: Set/Query port MTU commands Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 10/12] net/mlx5: Ethernet Datapath files Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 11/12] net/mlx5: Ethernet resources handling Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 12/12] net/mlx5: Ethernet driver Amir Vadai
2015-04-14 18:51 ` David Miller [this message]
2015-04-21 13:30 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414.145113.192331451516214119.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=achiad@mellanox.com \
--cc=amirv@mellanox.com \
--cc=idos@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=talal@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).