From: David Miller <davem@davemloft.net>
To: tglx@linutronix.de
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
peterz@infradead.org, mingo@kernel.org, dingtianhong@huawei.com,
zhangfei.gao@linaro.org, dan.carpenter@oracle.com,
netdev@vger.kernel.org
Subject: Re: [patch v2] net: hip04: Make tx coalesce timer actually work
Date: Wed, 15 Apr 2015 17:22:27 -0400 (EDT) [thread overview]
Message-ID: <20150415.172227.1813336970100255734.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.11.1504142140290.3845@nanos>
From: Thomas Gleixner <tglx@linutronix.de>
Date: Tue, 14 Apr 2015 21:42:42 +0200 (CEST)
> The code sets the expiry value of the timer to a relative value and
> starts it with hrtimer_start_expires. That's fine, but that only works
> once. The timer is started in relative mode, so the expiry value gets
> overwritten with the absolut expiry time (now + expiry).
>
> So once the timer expired, a new call to hrtimer_start_expires results
> in an immidiately expired timer, because the expiry value is
> already in the past.
>
> Use the proper mechanisms to (re)start the timer in the intended way.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Applied, thanks Thomas.
prev parent reply other threads:[~2015-04-15 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150413210009.682000343@linutronix.de>
2015-04-13 21:02 ` [patch 4/5] net: hip04: Make tx coalesce timer actually work Thomas Gleixner
2015-04-13 21:24 ` Arnd Bergmann
2015-04-13 21:42 ` Thomas Gleixner
2015-04-13 22:03 ` Arnd Bergmann
2015-04-13 22:08 ` Thomas Gleixner
2015-04-14 7:53 ` Ding Tianhong
2015-04-14 18:15 ` David Miller
2015-04-14 19:42 ` [patch v2] " Thomas Gleixner
2015-04-15 2:24 ` Ding Tianhong
2015-04-15 10:20 ` Arnd Bergmann
2015-04-15 21:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415.172227.1813336970100255734.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=dingtianhong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).