From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: Yuval.Mintz@qlogic.com, netdev@vger.kernel.org, bind@enas.net,
peter@hurleysoftware.com, Ariel.Elior@qlogic.com,
willemb@google.com
Subject: Re: [PATCH v2 net] bnx2x: Fix busy_poll vs netpoll
Date: Wed, 15 Apr 2015 17:25:40 -0400 (EDT) [thread overview]
Message-ID: <20150415.172540.2003542806481345239.davem@davemloft.net> (raw)
In-Reply-To: <1429062300.7346.64.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 14 Apr 2015 18:45:00 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Commit 9a2620c877454 ("bnx2x: prevent WARN during driver unload")
> switched the napi/busy_lock locking mechanism from spin_lock() into
> spin_lock_bh(), breaking inter-operability with netconsole, as netpoll
> disables interrupts prior to calling our napi mechanism.
>
> This switches the driver into using atomic assignments instead of the
> spinlock mechanisms previously employed.
>
> Based on initial patch from Yuval Mintz & Ariel Elior
>
> I basically added softirq starvation avoidance, and mixture
> of atomic operations, plain writes and barriers.
>
> Note this slightly reduces the overhead for this driver when no
> busy_poll sockets are in use.
>
> Fixes: 9a2620c877454 ("bnx2x: prevent WARN during driver unload")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2015-04-15 21:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 13:35 [PATCH net] bnx2x: Fix netpoll interoperability Yuval Mintz
2015-04-14 14:52 ` Eric Dumazet
2015-04-14 16:44 ` Yuval Mintz
2015-04-14 17:51 ` Eric Dumazet
2015-04-14 18:11 ` Yuval Mintz
2015-04-14 18:24 ` Eric Dumazet
2015-04-15 1:45 ` [PATCH v2 net] bnx2x: Fix busy_poll vs netpoll Eric Dumazet
2015-04-15 4:05 ` Yuval Mintz
2015-04-15 10:05 ` Eric Dumazet
2015-04-15 14:03 ` Yuval Mintz
2015-04-15 17:09 ` Eric Dumazet
2015-04-15 21:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415.172540.2003542806481345239.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@qlogic.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=bind@enas.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).