From: David Miller <davem@davemloft.net>
To: weiyj_lk@163.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, xiyou.wangcong@gmail.com,
yongjun_wei@trendmicro.com.cn, netdev@vger.kernel.org
Subject: Re: [PATCH -next] fou: Fix missing unlock on error in fou_nl_dump()
Date: Thu, 16 Apr 2015 12:11:39 -0400 (EDT) [thread overview]
Message-ID: <20150416.121139.1274893629327012249.davem@davemloft.net> (raw)
In-Reply-To: <1429186479-20265-1-git-send-email-weiyj_lk@163.com>
From: weiyj_lk@163.com
Date: Thu, 16 Apr 2015 20:14:39 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing unlock before return from function fou_nl_dump()
> in the error handling case.
>
> Fixes: 7a6c8c34e5b7 (fou: implement FOU_CMD_GET)
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Your patch adds a warning because you fail to remove the 'done'
label which is no longer used.
Cong Wang already submitted a patch which does remove the 'done'
field properly, so I will apply his version.
prev parent reply other threads:[~2015-04-16 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 12:14 [PATCH -next] fou: Fix missing unlock on error in fou_nl_dump() weiyj_lk
2015-04-16 16:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416.121139.1274893629327012249.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=weiyj_lk@163.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).