From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: cascardo@linux.vnet.ibm.com, Ian.Jackson@eu.citrix.com,
prashant@broadcom.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
vyasevich@gmail.com, xen-devel@lists.xensource.com,
netdev@vger.kernel.org, siva.kallam@broadcom.com,
sanjeevb@broadcom.com
Subject: Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]
Date: Thu, 16 Apr 2015 14:14:02 -0400 (EDT) [thread overview]
Message-ID: <20150416.141402.496529110341582886.davem@davemloft.net> (raw)
In-Reply-To: <1429202353.6668.5.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
From: Michael Chan <mchan@broadcom.com>
Date: Thu, 16 Apr 2015 09:39:13 -0700
> On Thu, 2015-04-16 at 09:24 -0300, cascardo@linux.vnet.ibm.com wrote:
>> Yes, this looks like the driver is not syncing the DMA buffers. Unmap is
>> supposed to synchronize as well.
>>
>
> For small rx packets (< 256 bytes), we sync the DMA buffer before we
> copy the data to another SKB. For larger packets, we unmap the DMA
> buffer. Do we see the corruption in both cases?
I wonder about that prefetch which is done before the DMA sync.
Also we should think about whether that DMA sync applies to the proper
region. The 'len' is relative to "data+TG3_RX_OFFSET" yet if I read
the code correctly we are effectively sync'ing from 'data' to
'data+len'.
There is some bug hiding in here I think...
next prev parent reply other threads:[~2015-04-16 18:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 15:12 tg3 NIC driver bug in 3.14.x under Xen Ian Jackson
2015-04-07 15:37 ` Konrad Rzeszutek Wilk
2015-04-07 18:25 ` Ian Jackson
2015-04-07 16:55 ` Michael Chan
2015-04-07 17:58 ` Ian Jackson
2015-04-07 18:13 ` Ian Jackson
2015-04-07 23:21 ` Michael Chan
2015-04-07 23:22 ` Prashant Sreedharan
2015-04-08 13:59 ` tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages] Ian Jackson
2015-04-09 1:43 ` Prashant Sreedharan
2015-04-09 11:11 ` Ian Jackson
2015-04-09 16:10 ` Prashant Sreedharan
2015-04-09 16:57 ` Ian Jackson
2015-04-09 17:25 ` Ian Jackson
2015-04-09 18:08 ` Prashant Sreedharan
2015-04-10 15:06 ` Ian Jackson
2015-04-11 8:01 ` Prashant
2015-04-15 10:54 ` Ian Jackson
2015-04-16 2:53 ` Prashant
2015-04-16 10:18 ` Ian Jackson
2015-04-16 12:24 ` cascardo
2015-04-16 16:39 ` Michael Chan
2015-04-16 17:15 ` Ian Jackson
2015-04-16 22:51 ` Prashant Sreedharan
2015-04-17 16:29 ` Ian Jackson
2015-04-17 17:19 ` David Miller
2015-04-17 17:46 ` Michael Chan
2015-04-17 19:04 ` Konrad Rzeszutek Wilk
2015-04-17 19:12 ` David Miller
2015-04-17 18:52 ` Prashant Sreedharan
2015-04-21 15:05 ` Ian Jackson
2015-04-16 18:14 ` David Miller [this message]
2015-04-09 18:26 ` Michael Chan
2015-04-10 11:43 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416.141402.496529110341582886.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ian.Jackson@eu.citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=cascardo@linux.vnet.ibm.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
--cc=sanjeevb@broadcom.com \
--cc=siva.kallam@broadcom.com \
--cc=vyasevich@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).