From: David Miller <davem@davemloft.net>
To: pure.logic@nexus-software.ie
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org,
andriy.shevchenko@linux.intel.com, hock.leong.kweh@intel.com,
boon.leong.ong@intel.com, dan.odonovan@emutex.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] stmmac: fix oops on rmmod after assigning ip addr
Date: Thu, 16 Apr 2015 14:14:27 -0400 (EDT) [thread overview]
Message-ID: <20150416.141427.1085248733060476395.davem@davemloft.net> (raw)
In-Reply-To: <1429203363-10919-2-git-send-email-pure.logic@nexus-software.ie>
From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Date: Thu, 16 Apr 2015 17:56:03 +0100
> An oops exists in the flow of stmmac_release().
> phy_ethtool_get_wol() depends on phydev->drv.
> phydev->drv will be null after stmmac_mdio_unreg() completes.
>
> Steps to reproduce on Quark X1000:
>
> 1. ifconfig eth0 192.168.0.1
> 2. rmmod stmmac_pci
>
> To fix this stmmac_mdio_unreg() should be run after unregister_netdev().
>
> Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
> Reported-by: Dan O'Donovan <dan.odonovan@emutex.com>
Applied.
prev parent reply other threads:[~2015-04-16 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 16:56 [PATCH v3 0/1] stmmac: rmmod oops after ifconfig Bryan O'Donoghue
2015-04-16 16:56 ` [PATCH v3 1/1] stmmac: fix oops on rmmod after assigning ip addr Bryan O'Donoghue
2015-04-16 18:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416.141427.1085248733060476395.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boon.leong.ong@intel.com \
--cc=dan.odonovan@emutex.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).