From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: James Morris <jmorris@namei.org>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
netdev@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-security-module@vger.kernel.org,
Flavio Leitner <fbl@sysclose.org>
Subject: Re: Revert "net: Reset secmark when scrubbing packet"
Date: Thu, 16 Apr 2015 09:32:09 +0100 [thread overview]
Message-ID: <20150416083209.GD32170@casper.infradead.org> (raw)
In-Reply-To: <20150416081253.GA13595@gondor.apana.org.au>
On 04/16/15 at 04:12pm, Herbert Xu wrote:
> On Thu, Apr 16, 2015 at 05:02:15PM +1000, James Morris wrote:
> >
> > They don't support namespaces, and maintaining the label is critical for
> > SELinux, at least, which mediates security for the system as a whole.
>
> Thanks for the confirmation James, I thought this looked a bit
> dodgy :)
>
> ---8<---
> This patch reverts commit b8fb4e0648a2ab3734140342002f68fb0c7d1602
> because the secmark must be preserved even when a packet crosses
> namespace boundaries. The reason is that security labels apply to
> the system as a whole and is not per-namespace.
No objection to reverting, _BUT_ just because security labels
apply to the system as a whole does not mean that both the packet
in the underlay and overlay belong to the same context.
The point here was to not blindly inherit the security context of a
packet based on the outer or inner header. Someone tagging all
packets addressed to the host itself with a SElinux context may not
expect that SELinux context to be preserved into a namespaced tenant.
next prev parent reply other threads:[~2015-04-16 8:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 10:01 ip_tunnel: Remove gratuitous skb scrubbing Herbert Xu
2015-04-15 10:13 ` Herbert Xu
2015-04-15 10:20 ` Nicolas Dichtel
2015-04-15 10:22 ` Herbert Xu
2015-04-15 10:28 ` Nicolas Dichtel
2015-04-15 10:32 ` Herbert Xu
2015-04-15 13:57 ` Herbert Xu
2015-04-15 15:41 ` Nicolas Dichtel
2015-04-16 1:03 ` [v3] skbuff: Do not scrub skb mark within the same name space Herbert Xu
2015-04-16 7:02 ` James Morris
2015-04-16 7:35 ` Nicolas Dichtel
2015-04-16 7:59 ` Herbert Xu
2015-04-16 8:12 ` Revert "net: Reset secmark when scrubbing packet" Herbert Xu
2015-04-16 8:32 ` Thomas Graf [this message]
2015-04-16 18:21 ` David Miller
2015-04-16 8:33 ` [v3] skbuff: Do not scrub skb mark within the same name space Thomas Graf
2015-04-16 18:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416083209.GD32170@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=ebiederm@xmission.com \
--cc=fbl@sysclose.org \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).