From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>,
David Miller <davem@davemloft.net>,
fw@strlen.de, netdev@vger.kernel.org
Subject: Re: [PATCH -next 0/3] net: cap size to original frag size when refragmenting
Date: Thu, 16 Apr 2015 22:56:46 +0200 [thread overview]
Message-ID: <20150416205646.GB4020@acer.localdomain> (raw)
In-Reply-To: <20150416204702.GA20616@gondor.apana.org.au>
On 17.04, Herbert Xu wrote:
> On Thu, Apr 16, 2015 at 06:13:25PM +0200, Hannes Frederic Sowa wrote:
> >
> > So currently we have one fast path, that is: we are not fragmented, we
> > get out non-fragmented, none of this code is ever touched and no
> > problem.
> >
> > We don't want to mak this more complex, but
>
> You should read Dave's other email where he gives you an obvious
> solution. If you have to modify the skb then you don't have to
> worry about the original fragments.
>
> But if you only read the skb then don't linearise it completely
> and keep the original fragments.
Yes, I was just responding to that. We need an additional member
in the skb, but then this part is quite simple.
next prev parent reply other threads:[~2015-04-16 20:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 22:16 [PATCH -next 0/3] net: cap size to original frag size when refragmenting Florian Westphal
2015-04-10 22:16 ` [PATCH -next 1/3] ipv4: reject too-big defragmented DF-skb when forwarding Florian Westphal
2015-04-10 22:51 ` Hannes Frederic Sowa
2015-04-10 22:16 ` [PATCH -next 2/3] ipv6: don't increase size when refragmenting forwarded skbs Florian Westphal
2015-04-10 22:16 ` [PATCH -next 3/3] ipv4: don't remove df bit when refragmenting Florian Westphal
2015-04-12 8:51 ` Florian Westphal
2015-04-13 17:53 ` [PATCH -next 0/3] net: cap size to original frag size " David Miller
2015-04-13 18:40 ` Hannes Frederic Sowa
2015-04-13 18:56 ` Hannes Frederic Sowa
2015-04-13 20:16 ` David Miller
2015-04-13 20:33 ` Hannes Frederic Sowa
2015-04-16 4:56 ` Herbert Xu
2015-04-16 5:24 ` Patrick McHardy
2015-04-16 5:29 ` Herbert Xu
2015-04-16 5:42 ` Patrick McHardy
2015-04-16 12:11 ` Hannes Frederic Sowa
2015-04-16 15:43 ` David Miller
2015-04-16 16:13 ` Hannes Frederic Sowa
2015-04-16 20:47 ` Herbert Xu
2015-04-16 20:56 ` Patrick McHardy [this message]
2015-04-16 23:16 ` Hannes Frederic Sowa
2015-04-16 23:44 ` Patrick McHardy
2015-04-16 20:32 ` Patrick McHardy
2015-04-16 15:32 ` David Miller
2015-04-16 20:55 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416205646.GB4020@acer.localdomain \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=hannes@stressinduktion.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox