From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: netdev@vger.kernel.org, therbert@google.com, jesse@nicira.com,
johannes.berg@intel.com
Subject: Re: [PATCH] net: remove unused 'dev' argument from netif_needs_gso()
Date: Fri, 17 Apr 2015 13:29:09 -0400 (EDT) [thread overview]
Message-ID: <20150417.132909.1859863736464111217.davem@davemloft.net> (raw)
In-Reply-To: <1429278304-22260-1-git-send-email-johannes@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Fri, 17 Apr 2015 15:45:04 +0200
> From: Johannes Berg <johannes.berg@intel.com>
>
> In commit 04ffcb255f22 ("net: Add ndo_gso_check") Tom originally
> added the 'dev' argument to be able to call ndo_gso_check().
>
> Then later, when generalizing this in commit 5f35227ea34b
> ("net: Generalize ndo_gso_check to ndo_features_check")
> Jesse removed the call to ndo_gso_check() in netif_needs_gso()
> by calling the new ndo_features_check() in a different place.
> This made the 'dev' argument unused.
>
> Remove the unused argument and go back to the code as before.
>
> Cc: Tom Herbert <therbert@google.com>
> Cc: Jesse Gross <jesse@nicira.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Applied.
prev parent reply other threads:[~2015-04-17 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 13:45 [PATCH] net: remove unused 'dev' argument from netif_needs_gso() Johannes Berg
2015-04-17 17:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417.132909.1859863736464111217.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).