From: David Miller <davem@davemloft.net>
To: dvlasenk@redhat.com
Cc: eric.dumazet@gmail.com, ebiederm@xmission.com,
jengelh@medozas.de, jpirko@redhat.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netns: deinline net_generic()
Date: Fri, 17 Apr 2015 15:55:32 -0400 (EDT) [thread overview]
Message-ID: <20150417.155532.328134690699313472.davem@davemloft.net> (raw)
In-Reply-To: <55313D4D.4050402@redhat.com>
From: Denys Vlasenko <dvlasenk@redhat.com>
Date: Fri, 17 Apr 2015 19:05:17 +0200
> On 04/16/2015 02:38 PM, Eric Dumazet wrote:
>> On Thu, 2015-04-16 at 13:14 +0200, Denys Vlasenko wrote:
>>
>>> However, without BUG_ONs, function is still a bit big
>>> on PREEMPT configs.
>>
>> Only on allyesconfig builds, that nobody use but to prove some points
>> about code size.
>
> How do you expect one to find excessively large inlines,
> if not on allyesconfig build?
>
> Only by using allyesconfig, I can measure how many calls
> are there in the kernel. (grepping source is utterly unreliable
> due to nested inlines and macros).
It is not indicative for it's overhead in what people actually make
use of, which is what is actually important.
Uninlining a static inline that basically does no more than index into
an array is nothing more than pure folly. So please don't try to
weasel your way out of accepting this basic fact.
That's exactly the situation where the implementation of an abstraction
via a static inline is exactly the thing to do.
next prev parent reply other threads:[~2015-04-17 19:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 12:25 [PATCH] netns: deinline net_generic() Denys Vlasenko
2015-04-14 12:36 ` Jiri Pirko
2015-04-14 13:19 ` Eric Dumazet
2015-04-14 13:57 ` Denys Vlasenko
2015-04-14 14:21 ` Eric Dumazet
2015-04-14 15:04 ` Denys Vlasenko
2015-04-14 15:25 ` Eric Dumazet
2015-04-14 18:37 ` David Miller
2015-04-16 11:14 ` Denys Vlasenko
2015-04-16 12:38 ` Eric Dumazet
2015-04-17 17:05 ` Denys Vlasenko
2015-04-17 17:42 ` Eric Dumazet
2015-04-17 18:05 ` Denys Vlasenko
2015-04-17 18:55 ` David Miller
2015-04-17 19:55 ` David Miller [this message]
2015-04-16 15:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417.155532.328134690699313472.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dvlasenk@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=jengelh@medozas.de \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).