From: David Miller <davem@davemloft.net>
To: sebastian.poehn@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] ip_forward: Drop frames with attached skb->sk
Date: Mon, 20 Apr 2015 14:08:25 -0400 (EDT) [thread overview]
Message-ID: <20150420.140825.121616346767140780.davem@davemloft.net> (raw)
In-Reply-To: <1429514360.7091.9.camel@googlemail.com>
From: Sebastian Poehn <sebastian.poehn@gmail.com>
Date: Mon, 20 Apr 2015 09:19:20 +0200
> Initial discussion was:
> [FYI] xfrm: Don't lookup sk_policy for timewait sockets
>
> Forwarded frames should not have a socket attached. Especially
> tw sockets will lead to panics later-on in the stack.
>
> This was observed with TPROXY assigning a tw socket and broken
> policy routing (misconfigured). As a result frame enters
> forwarding path instead of input. We cannot solve this in
> TPROXY as it cannot know that policy routing is broken.
>
> v2:
> Remove useless comment
>
> Signed-off-by: Sebastian Poehn <sebastian.poehn@gmail.com>
Applied and queued up for -stable, thanks Sebastian.
prev parent reply other threads:[~2015-04-20 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 7:19 [PATCH v2] ip_forward: Drop frames with attached skb->sk Sebastian Poehn
2015-04-20 18:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420.140825.121616346767140780.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sebastian.poehn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).