From: David Miller <davem@davemloft.net>
To: mateusz.kulikowski@gmail.com
Cc: joe@perches.com, dan.carpenter@oracle.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] etherdevice: Add ether_addr_copy_unaligned
Date: Mon, 20 Apr 2015 14:19:14 -0400 (EDT) [thread overview]
Message-ID: <20150420.141914.1605864056122893264.davem@davemloft.net> (raw)
In-Reply-To: <1429479577-3977-1-git-send-email-mateusz.kulikowski@gmail.com>
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Date: Sun, 19 Apr 2015 23:39:37 +0200
> Some drivers require copying unaligned ethernet addresses.
> Using memcpy() causes checkpatch warnings and may cause
> regressions (someone will "fix" alignment of packed structure)
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
I'd rather see something like this submitted in a patch series alongside
some actual uses.
So I'm tossing this for now.
next prev parent reply other threads:[~2015-04-20 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 21:39 [PATCH] etherdevice: Add ether_addr_copy_unaligned Mateusz Kulikowski
2015-04-20 18:19 ` David Miller [this message]
2015-04-21 20:06 ` Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420.141914.1605864056122893264.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).