netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: joakim.tjernlund@transmode.se
Cc: netdev@vger.kernel.org
Subject: Re: [PATCHv3] pppoe: Lacks DST MAC address check
Date: Mon, 20 Apr 2015 15:27:28 -0400 (EDT)	[thread overview]
Message-ID: <20150420.152728.2303510459953341238.davem@davemloft.net> (raw)
In-Reply-To: <1429556868-28640-1-git-send-email-joakim.tjernlund@transmode.se>

From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Date: Mon, 20 Apr 2015 21:07:48 +0200

> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> 
> A pppoe session is identified by its session ID and MAC address.
> Currently pppoe does not check if the received pkg has the correct
> MAC address. This is a problem when the eth I/F is in promisc mode
> as then any DST MAC address is accepted.
> 
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
> ---
>  drivers/net/ppp/pppoe.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> v2 - The MAC address check should encompass all pppoe pkgs,
>      not only the relay type.
> 
> v3 - Add signoff

Applied, thanks.

      reply	other threads:[~2015-04-20 19:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 19:07 [PATCHv3] pppoe: Lacks DST MAC address check Joakim Tjernlund
2015-04-20 19:27 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150420.152728.2303510459953341238.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=joakim.tjernlund@transmode.se \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).