* [PATCHv3] pppoe: Lacks DST MAC address check
@ 2015-04-20 19:07 Joakim Tjernlund
2015-04-20 19:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Joakim Tjernlund @ 2015-04-20 19:07 UTC (permalink / raw)
To: netdev; +Cc: Joakim Tjernlund, Joakim Tjernlund
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
A pppoe session is identified by its session ID and MAC address.
Currently pppoe does not check if the received pkg has the correct
MAC address. This is a problem when the eth I/F is in promisc mode
as then any DST MAC address is accepted.
Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
---
drivers/net/ppp/pppoe.c | 3 +++
1 file changed, 3 insertions(+)
v2 - The MAC address check should encompass all pppoe pkgs,
not only the relay type.
v3 - Add signoff
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index ff059e1..aa1dd92 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -380,6 +380,9 @@ static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb)
* can't change.
*/
+ if (skb->pkt_type == PACKET_OTHERHOST)
+ goto abort_kfree;
+
if (sk->sk_state & PPPOX_BOUND) {
ppp_input(&po->chan, skb);
} else if (sk->sk_state & PPPOX_RELAY) {
--
2.0.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv3] pppoe: Lacks DST MAC address check
2015-04-20 19:07 [PATCHv3] pppoe: Lacks DST MAC address check Joakim Tjernlund
@ 2015-04-20 19:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-04-20 19:27 UTC (permalink / raw)
To: joakim.tjernlund; +Cc: netdev
From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Date: Mon, 20 Apr 2015 21:07:48 +0200
> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>
> A pppoe session is identified by its session ID and MAC address.
> Currently pppoe does not check if the received pkg has the correct
> MAC address. This is a problem when the eth I/F is in promisc mode
> as then any DST MAC address is accepted.
>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
> ---
> drivers/net/ppp/pppoe.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> v2 - The MAC address check should encompass all pppoe pkgs,
> not only the relay type.
>
> v3 - Add signoff
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-20 19:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-20 19:07 [PATCHv3] pppoe: Lacks DST MAC address check Joakim Tjernlund
2015-04-20 19:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).