From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org,
linux@roeck-us.net, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix setup of port control 1
Date: Mon, 20 Apr 2015 22:01:53 -0400 (EDT) [thread overview]
Message-ID: <20150420.220153.1027836111884807798.davem@davemloft.net> (raw)
In-Reply-To: <20150420230507.GC32294@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 21 Apr 2015 01:05:07 +0200
> On Mon, Apr 20, 2015 at 05:19:23PM -0400, Vivien Didelot wrote:
>> mv88e6xxx_setup_port_common was writing to PORT_DEFAULT_VLAN (port
>> offset 0x07) instead of PORT_CONTROL_1 (port offset 0x05).
>
> Hi Vivien
>
> Good catch.
>
>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
> Fixes: cca8b1337541 ("net: dsa: Use mnemonics rather than register numbers")
> Acked-by: Andrew Lunn <andrew@lunn.ch>
Applied.
prev parent reply other threads:[~2015-04-21 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 21:19 [PATCH] net: dsa: mv88e6xxx: fix setup of port control 1 Vivien Didelot
2015-04-20 23:05 ` Andrew Lunn
2015-04-21 2:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420.220153.1027836111884807798.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).