* [PATCH] net: dsa: mv88e6xxx: fix setup of port control 1
@ 2015-04-20 21:19 Vivien Didelot
2015-04-20 23:05 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Vivien Didelot @ 2015-04-20 21:19 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Guenter Roeck, linux-kernel, kernel,
Vivien Didelot
mv88e6xxx_setup_port_common was writing to PORT_DEFAULT_VLAN (port
offset 0x07) instead of PORT_CONTROL_1 (port offset 0x05).
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
drivers/net/dsa/mv88e6xxx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 9f0c2b9..48712bd 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -1251,8 +1251,7 @@ int mv88e6xxx_setup_port_common(struct dsa_switch *ds, int port)
/* Port Control 1: disable trunking, disable sending
* learning messages to this port.
*/
- ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_DEFAULT_VLAN,
- 0x0000);
+ ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_CONTROL_1, 0x0000);
if (ret)
goto abort;
--
2.3.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: fix setup of port control 1
2015-04-20 21:19 [PATCH] net: dsa: mv88e6xxx: fix setup of port control 1 Vivien Didelot
@ 2015-04-20 23:05 ` Andrew Lunn
2015-04-21 2:01 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2015-04-20 23:05 UTC (permalink / raw)
To: Vivien Didelot
Cc: netdev, David S. Miller, Guenter Roeck, linux-kernel, kernel
On Mon, Apr 20, 2015 at 05:19:23PM -0400, Vivien Didelot wrote:
> mv88e6xxx_setup_port_common was writing to PORT_DEFAULT_VLAN (port
> offset 0x07) instead of PORT_CONTROL_1 (port offset 0x05).
Hi Vivien
Good catch.
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Fixes: cca8b1337541 ("net: dsa: Use mnemonics rather than register numbers")
Acked-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> drivers/net/dsa/mv88e6xxx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
> index 9f0c2b9..48712bd 100644
> --- a/drivers/net/dsa/mv88e6xxx.c
> +++ b/drivers/net/dsa/mv88e6xxx.c
> @@ -1251,8 +1251,7 @@ int mv88e6xxx_setup_port_common(struct dsa_switch *ds, int port)
> /* Port Control 1: disable trunking, disable sending
> * learning messages to this port.
> */
> - ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_DEFAULT_VLAN,
> - 0x0000);
> + ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_CONTROL_1, 0x0000);
> if (ret)
> goto abort;
>
> --
> 2.3.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: dsa: mv88e6xxx: fix setup of port control 1
2015-04-20 23:05 ` Andrew Lunn
@ 2015-04-21 2:01 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2015-04-21 2:01 UTC (permalink / raw)
To: andrew; +Cc: vivien.didelot, netdev, linux, linux-kernel, kernel
From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 21 Apr 2015 01:05:07 +0200
> On Mon, Apr 20, 2015 at 05:19:23PM -0400, Vivien Didelot wrote:
>> mv88e6xxx_setup_port_common was writing to PORT_DEFAULT_VLAN (port
>> offset 0x07) instead of PORT_CONTROL_1 (port offset 0x05).
>
> Hi Vivien
>
> Good catch.
>
>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
> Fixes: cca8b1337541 ("net: dsa: Use mnemonics rather than register numbers")
> Acked-by: Andrew Lunn <andrew@lunn.ch>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-21 2:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-20 21:19 [PATCH] net: dsa: mv88e6xxx: fix setup of port control 1 Vivien Didelot
2015-04-20 23:05 ` Andrew Lunn
2015-04-21 2:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).