* [PATCH] net: dsa: mv88e6xxx: use PORT_DEFAULT_VLAN
@ 2015-04-20 21:43 Vivien Didelot
2015-04-20 23:00 ` Andrew Lunn
2015-04-21 2:01 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Vivien Didelot @ 2015-04-20 21:43 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Guenter Roeck, linux-kernel, kernel,
Vivien Didelot
Minor, use the explicit PORT_DEFAULT_VLAN define instead of 0x07.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
drivers/net/dsa/mv88e6xxx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 48712bd..af639ab 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -1274,7 +1274,8 @@ int mv88e6xxx_setup_port_common(struct dsa_switch *ds, int port)
/* Default VLAN ID and priority: don't set a default VLAN
* ID, and set the default packet priority to zero.
*/
- ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), 0x07, 0x0000);
+ ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_DEFAULT_VLAN,
+ 0x0000);
abort:
mutex_unlock(&ps->smi_mutex);
return ret;
--
2.3.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: use PORT_DEFAULT_VLAN
2015-04-20 21:43 [PATCH] net: dsa: mv88e6xxx: use PORT_DEFAULT_VLAN Vivien Didelot
@ 2015-04-20 23:00 ` Andrew Lunn
2015-04-21 2:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2015-04-20 23:00 UTC (permalink / raw)
To: Vivien Didelot
Cc: netdev, David S. Miller, Guenter Roeck, linux-kernel, kernel
On Mon, Apr 20, 2015 at 05:43:26PM -0400, Vivien Didelot wrote:
> Minor, use the explicit PORT_DEFAULT_VLAN define instead of 0x07.
Hi Vivien
I would not normally use the word "Minor" here, since it will end up
in the commit log.
Other than that:
Acked-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
> drivers/net/dsa/mv88e6xxx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
> index 48712bd..af639ab 100644
> --- a/drivers/net/dsa/mv88e6xxx.c
> +++ b/drivers/net/dsa/mv88e6xxx.c
> @@ -1274,7 +1274,8 @@ int mv88e6xxx_setup_port_common(struct dsa_switch *ds, int port)
> /* Default VLAN ID and priority: don't set a default VLAN
> * ID, and set the default packet priority to zero.
> */
> - ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), 0x07, 0x0000);
> + ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), PORT_DEFAULT_VLAN,
> + 0x0000);
> abort:
> mutex_unlock(&ps->smi_mutex);
> return ret;
> --
> 2.3.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: mv88e6xxx: use PORT_DEFAULT_VLAN
2015-04-20 21:43 [PATCH] net: dsa: mv88e6xxx: use PORT_DEFAULT_VLAN Vivien Didelot
2015-04-20 23:00 ` Andrew Lunn
@ 2015-04-21 2:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-04-21 2:01 UTC (permalink / raw)
To: vivien.didelot; +Cc: netdev, linux, linux-kernel, kernel
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Mon, 20 Apr 2015 17:43:26 -0400
> Minor, use the explicit PORT_DEFAULT_VLAN define instead of 0x07.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-21 2:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-20 21:43 [PATCH] net: dsa: mv88e6xxx: use PORT_DEFAULT_VLAN Vivien Didelot
2015-04-20 23:00 ` Andrew Lunn
2015-04-21 2:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).