[PATCH 1/1] altera tse: Error-Bit on tx-avalon-stream always set.

[PATCH 1/1] altera tse: Error-Bit on tx-avalon-stream always set.

[Andreas Oetken]

From: Andreas Oetken <ennoerlangen@gmail.com>

The Error-Bit on the avalon streaming interface of the
tx-dma-channel was always set. In SGMII configurations
this leads to error-symbols on the PCS and packet-rejection
on the receiver side (e.g. SGMII/1000Base-X connected switch).

This only applies to the tse-configuration with MSGDMA.

This issue was detected and fixed on a custom board with
a direct connection to a Marvell switch in SGMII-PHY-Mode.
(incl. custom patches for SGMII-PCS).

According to the datasheet if ff_tx_err (avalon-streaming)
is set it is forwarded to gm_tx_err. As a result the PCS
is forwarding the error by sending a "/V/"-caracter.

Signed-off-by: Andreas Oetken <ennoerlangen@gmail.com>
---
 drivers/net/ethernet/altera/altera_msgdmahw.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/altera/altera_msgdmahw.h b/drivers/net/ethernet/altera/altera_msgdmahw.h
index e335626..eba070f 100644
--- a/drivers/net/ethernet/altera/altera_msgdmahw.h
+++ b/drivers/net/ethernet/altera/altera_msgdmahw.h
@@ -72,7 +72,6 @@ struct msgdma_extended_desc {
 #define MSGDMA_DESC_CTL_TX_SINGLE	(MSGDMA_DESC_CTL_GEN_SOP |	\
 					 MSGDMA_DESC_CTL_GEN_EOP |	\
 					 MSGDMA_DESC_CTL_TR_COMP_IRQ |	\
-					 MSGDMA_DESC_CTL_TR_ERR_IRQ |	\
 					 MSGDMA_DESC_CTL_GO)
 
 #define MSGDMA_DESC_CTL_RX_SINGLE	(MSGDMA_DESC_CTL_END_ON_EOP |	\
-- 
2.1.4

Re: [PATCH 1/1] altera tse: Error-Bit on tx-avalon-stream always set.

[David Miller]

From: Andreas Oetken <ennoerlangen@googlemail.com>
Date: Tue, 21 Apr 2015 00:16:38 +0200

> From: Andreas Oetken <ennoerlangen@gmail.com>
> 
> The Error-Bit on the avalon streaming interface of the
> tx-dma-channel was always set. In SGMII configurations
> this leads to error-symbols on the PCS and packet-rejection
> on the receiver side (e.g. SGMII/1000Base-X connected switch).
> 
> This only applies to the tse-configuration with MSGDMA.
> 
> This issue was detected and fixed on a custom board with
> a direct connection to a Marvell switch in SGMII-PHY-Mode.
> (incl. custom patches for SGMII-PCS).
> 
> According to the datasheet if ff_tx_err (avalon-streaming)
> is set it is forwarded to gm_tx_err. As a result the PCS
> is forwarding the error by sending a "/V/"-caracter.
> 
> Signed-off-by: Andreas Oetken <ennoerlangen@gmail.com>

Applied.