From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: johunt@akamai.com, netdev@vger.kernel.org, edumazet@google.com,
gthelen@google.com, rientjes@google.com
Subject: Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()
Date: Wed, 22 Apr 2015 14:50:14 -0400 (EDT) [thread overview]
Message-ID: <20150422.145014.115419919912486761.davem@davemloft.net> (raw)
In-Reply-To: <1429727967.18561.129.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 22 Apr 2015 11:39:27 -0700
> Note that in the unlikely case skb can not be allocated,
> if an already transmitted packet is in the write queue, we also can OR
> the FIN flag on it, and rely on normal rtx to deliver this FIN later.
>
> I'll cook a patch when net-next reopens.
Hmmm, we already check for something like this at the beginning of
tcp_send_fin(), I know because I added that piece of code 15+ years
ago :-)
Or are you suggesting something slightly different?
next prev parent reply other threads:[~2015-04-22 18:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 23:19 [PATCH] fix tcp fin memory accounting Josh Hunt
2015-03-20 2:17 ` Eric Dumazet
2015-03-20 17:20 ` David Miller
2015-03-20 17:36 ` Josh Hunt
2015-03-24 6:10 ` David Miller
2015-03-24 6:11 ` Josh Hunt
2015-04-22 0:09 ` Eric Dumazet
2015-04-22 1:32 ` [PATCH net] tcp: fix possible deadlock in tcp_send_fin() Eric Dumazet
2015-04-22 14:33 ` [PATCH net] net: do not deplete pfmemalloc reserve Eric Dumazet
2015-04-22 19:35 ` David Miller
2015-04-22 20:20 ` Eric Dumazet
2015-04-22 20:24 ` David Miller
2015-04-22 18:15 ` [PATCH net] tcp: fix possible deadlock in tcp_send_fin() David Miller
2015-04-22 18:39 ` Eric Dumazet
2015-04-22 18:50 ` David Miller [this message]
2015-04-22 19:12 ` Eric Dumazet
2015-04-22 19:29 ` David Miller
2015-04-23 13:48 ` [PATCH] fix tcp fin memory accounting Josh Hunt
2015-04-23 14:02 ` Eric Dumazet
2015-04-23 15:54 ` David Miller
2015-04-23 16:16 ` Eric Dumazet
2015-04-23 16:48 ` Eric Dumazet
2015-04-23 17:12 ` David Miller
2015-04-23 17:42 ` [PATCH net] tcp: avoid looping in tcp_send_fin() Eric Dumazet
2015-04-24 15:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422.145014.115419919912486761.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gthelen@google.com \
--cc=johunt@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).