From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: ivecera@redhat.com, netdev@vger.kernel.org,
sathya.perla@emulex.com, subbu.seetharaman@emulex.com,
ajit.khaparde@emulex.com
Subject: Re: [PATCH net-next v2] be2net: log link status
Date: Wed, 22 Apr 2015 18:44:32 -0400 (EDT) [thread overview]
Message-ID: <20150422.184432.822632448362339441.davem@davemloft.net> (raw)
In-Reply-To: <1429711674.32612.8.camel@perches.com>
From: Joe Perches <joe@perches.com>
Date: Wed, 22 Apr 2015 07:07:54 -0700
> On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote:
>> @@ -658,10 +659,18 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
>> adapter->flags |= BE_FLAGS_LINK_STATUS_INIT;
>> }
>>
>> - if (link_status)
>> + if (link_status) {
>> + if (speed)
>> + /* Print speed only when it is known */
>> + netdev_info(netdev, "Link is Up at %d Mbps\n", speed);
>
> signed/unsigned mismatch. %u, speed
Indeed, please fix this up and resubmit, thanks.
next prev parent reply other threads:[~2015-04-22 22:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 13:43 [PATCH net-next v2] be2net: log link status Ivan Vecera
2015-04-22 14:07 ` Joe Perches
2015-04-22 14:17 ` Ivan Vecera
2015-04-22 22:44 ` David Miller [this message]
2015-04-23 6:35 ` Sathya Perla
2015-04-23 6:31 ` Sathya Perla
2015-04-23 6:52 ` Ivan Vecera
2015-04-28 14:32 ` Ivan Vecera
2015-04-28 16:44 ` David Miller
2015-04-28 19:32 ` Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422.184432.822632448362339441.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@emulex.com \
--cc=ivecera@redhat.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
--cc=subbu.seetharaman@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).