From: Thomas Graf <tgraf@suug.ch>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] rhashtable: Schedule async resize when sync realloc fails
Date: Wed, 22 Apr 2015 08:18:05 +0100 [thread overview]
Message-ID: <20150422071805.GD21799@casper.infradead.org> (raw)
In-Reply-To: <20150421.221033.573953908362966477.davem@davemloft.net>
On 04/21/15 at 10:10pm, David Miller wrote:
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Wed, 22 Apr 2015 08:36:34 +0800
>
> > On Tue, Apr 21, 2015 at 02:55:34PM +0200, Thomas Graf wrote:
> >> When rhashtable_insert_rehash() fails with ENOMEM, this indicates that
> >> we can't allocate the necessary memory in the current context but the
> >> limits as set by the user would still allow to grow.
> >>
> >> Thus attempt an async resize in the background where we can allocate
> >> using GFP_KERNEL which is more likely to succeed. The insertion itself
> >> will still fail to indicate pressure.
> >>
> >> This fixes a bug where the table would never continue growing once the
> >> utilization is above 100%.
> >>
> >> Fixes: ccd57b1bd324 ("rhashtable: Add immediate rehash during insertion")
> >> Signed-off-by: Thomas Graf <tgraf@suug.ch>
> >
> > Good catch. But I think this call should happen in
> > rhashtable_insert_rehash since it's on the slow-path.
>
> Ok, then I expect a respin of this series.
Agreed, respinning.
next prev parent reply other threads:[~2015-04-22 7:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 12:55 [PATCH net 0/2] rhashtable rehashing fixes Thomas Graf
2015-04-21 12:55 ` [PATCH net 1/2] rhashtable: Schedule async resize when sync realloc fails Thomas Graf
2015-04-22 0:36 ` Herbert Xu
2015-04-22 2:10 ` David Miller
2015-04-22 7:18 ` Thomas Graf [this message]
2015-04-21 12:55 ` [PATCH net 2/2] rhashtable: Do not schedule more than one rehash if we can't grow further Thomas Graf
2015-04-22 0:37 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2015-04-22 7:41 [PATCH net 0/2 v2] rhashtable rehashing fixes Thomas Graf
2015-04-22 7:41 ` [PATCH net 1/2] rhashtable: Schedule async resize when sync realloc fails Thomas Graf
2015-04-22 7:43 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422071805.GD21799@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).