netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ethernet: amd: AMD_XGBE should depend on HAS_DMA
@ 2015-04-23 17:59 Geert Uytterhoeven
  2015-04-23 17:59 ` [PATCH 2/2] ethernet: arc: ARC_EMAC and EMAC_ROCKCHIP " Geert Uytterhoeven
  2015-04-23 18:10 ` [PATCH 1/2] ethernet: amd: AMD_XGBE " David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2015-04-23 17:59 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, linux-kernel, Geert Uytterhoeven

If NO_DMA=y:

    drivers/built-in.o: In function `xgbe_probe':
    xgbe-main.c:(.text+0x2def0a): undefined reference to `dma_set_mask'
    xgbe-main.c:(.text+0x2def20): undefined reference to `dma_supported'
    drivers/built-in.o: In function `xgbe_rx_poll':
    xgbe-drv.c:(.text+0x2e0320): undefined reference to `dma_sync_single_for_cpu'
    xgbe-drv.c:(.text+0x2e035e): undefined reference to `dma_sync_single_for_cpu'
    drivers/built-in.o: In function `xgbe_unmap_rdata':
    xgbe-desc.c:(.text+0x2e5fe4): undefined reference to `dma_unmap_page'
    xgbe-desc.c:(.text+0x2e5ffa): undefined reference to `dma_unmap_single'
    xgbe-desc.c:(.text+0x2e604a): undefined reference to `dma_unmap_page'
    xgbe-desc.c:(.text+0x2e6084): undefined reference to `dma_unmap_page'
    drivers/built-in.o: In function `xgbe_alloc_pages':
    xgbe-desc.c:(.text+0x2e6156): undefined reference to `dma_map_page'
    xgbe-desc.c:(.text+0x2e6164): undefined reference to `dma_mapping_error'
    drivers/built-in.o: In function `xgbe_free_ring':
    xgbe-desc.c:(.text+0x2e63d4): undefined reference to `dma_unmap_page'
    xgbe-desc.c:(.text+0x2e640e): undefined reference to `dma_unmap_page'
    xgbe-desc.c:(.text+0x2e644a): undefined reference to `dma_free_coherent'
    drivers/built-in.o: In function `xgbe_init_ring':
    xgbe-desc.c:(.text+0x2e64d4): undefined reference to `dma_alloc_coherent'
    drivers/built-in.o: In function `xgbe_map_tx_skb':
    xgbe-desc.c:(.text+0x2e6628): undefined reference to `dma_map_single'
    xgbe-desc.c:(.text+0x2e6638): undefined reference to `dma_mapping_error'
    xgbe-desc.c:(.text+0x2e66b2): undefined reference to `dma_map_single'
    xgbe-desc.c:(.text+0x2e66c2): undefined reference to `dma_mapping_error'
    xgbe-desc.c:(.text+0x2e6762): undefined reference to `dma_map_page'
    xgbe-desc.c:(.text+0x2e6772): undefined reference to `dma_mapping_error'

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/ethernet/amd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/Kconfig b/drivers/net/ethernet/amd/Kconfig
index c638c85f3954bc68..089c269637b725da 100644
--- a/drivers/net/ethernet/amd/Kconfig
+++ b/drivers/net/ethernet/amd/Kconfig
@@ -179,7 +179,7 @@ config SUNLANCE
 
 config AMD_XGBE
 	tristate "AMD 10GbE Ethernet driver"
-	depends on (OF_NET || ACPI) && HAS_IOMEM
+	depends on (OF_NET || ACPI) && HAS_IOMEM && HAS_DMA
 	select PHYLIB
 	select AMD_XGBE_PHY
 	select BITREVERSE
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ethernet: arc: ARC_EMAC and EMAC_ROCKCHIP should depend on HAS_DMA
  2015-04-23 17:59 [PATCH 1/2] ethernet: amd: AMD_XGBE should depend on HAS_DMA Geert Uytterhoeven
@ 2015-04-23 17:59 ` Geert Uytterhoeven
  2015-04-23 18:10   ` David Miller
  2015-04-23 18:10 ` [PATCH 1/2] ethernet: amd: AMD_XGBE " David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2015-04-23 17:59 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, linux-kernel, Geert Uytterhoeven

If NO_DMA=y:

    drivers/built-in.o: In function `arc_emac_tx_clean':
    emac_main.c:(.text+0x2decde): undefined reference to `dma_unmap_single'
    drivers/built-in.o: In function `arc_emac_rx':
    emac_main.c:(.text+0x2dee1c): undefined reference to `dma_unmap_single'
    emac_main.c:(.text+0x2dee72): undefined reference to `dma_map_single'
    emac_main.c:(.text+0x2dee7e): undefined reference to `dma_mapping_error'
    drivers/built-in.o: In function `arc_emac_probe':
    (.text+0x2df2ee): undefined reference to `dmam_alloc_coherent'
    drivers/built-in.o: In function `arc_emac_open':
    emac_main.c:(.text+0x2df6d8): undefined reference to `dma_map_single'
    emac_main.c:(.text+0x2df6e4): undefined reference to `dma_mapping_error'
    drivers/built-in.o: In function `arc_emac_tx':
    emac_main.c:(.text+0x2df9e4): undefined reference to `dma_map_single'
    emac_main.c:(.text+0x2df9f0): undefined reference to `dma_mapping_error'

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/ethernet/arc/Kconfig | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/arc/Kconfig b/drivers/net/ethernet/arc/Kconfig
index 8e262e2b39b63fc5..dea29ee24da4a28c 100644
--- a/drivers/net/ethernet/arc/Kconfig
+++ b/drivers/net/ethernet/arc/Kconfig
@@ -25,8 +25,7 @@ config ARC_EMAC_CORE
 config ARC_EMAC
 	tristate "ARC EMAC support"
 	select ARC_EMAC_CORE
-	depends on OF_IRQ
-	depends on OF_NET
+	depends on OF_IRQ && OF_NET && HAS_DMA
 	---help---
 	  On some legacy ARC (Synopsys) FPGA boards such as ARCAngel4/ML50x
 	  non-standard on-chip ethernet device ARC EMAC 10/100 is used.
@@ -35,7 +34,7 @@ config ARC_EMAC
 config EMAC_ROCKCHIP
 	tristate "Rockchip EMAC support"
 	select ARC_EMAC_CORE
-	depends on OF_IRQ && OF_NET && REGULATOR
+	depends on OF_IRQ && OF_NET && REGULATOR && HAS_DMA
 	---help---
 	  Support for Rockchip RK3066/RK3188 EMAC ethernet controllers.
 	  This selects Rockchip SoC glue layer support for the
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] ethernet: amd: AMD_XGBE should depend on HAS_DMA
  2015-04-23 17:59 [PATCH 1/2] ethernet: amd: AMD_XGBE should depend on HAS_DMA Geert Uytterhoeven
  2015-04-23 17:59 ` [PATCH 2/2] ethernet: arc: ARC_EMAC and EMAC_ROCKCHIP " Geert Uytterhoeven
@ 2015-04-23 18:10 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2015-04-23 18:10 UTC (permalink / raw)
  To: geert; +Cc: netdev, linux-kernel

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 23 Apr 2015 19:59:33 +0200

> If NO_DMA=y:
 ...
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] ethernet: arc: ARC_EMAC and EMAC_ROCKCHIP should depend on HAS_DMA
  2015-04-23 17:59 ` [PATCH 2/2] ethernet: arc: ARC_EMAC and EMAC_ROCKCHIP " Geert Uytterhoeven
@ 2015-04-23 18:10   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-04-23 18:10 UTC (permalink / raw)
  To: geert; +Cc: netdev, linux-kernel

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 23 Apr 2015 19:59:34 +0200

> If NO_DMA=y:
 ...
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-04-23 18:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-23 17:59 [PATCH 1/2] ethernet: amd: AMD_XGBE should depend on HAS_DMA Geert Uytterhoeven
2015-04-23 17:59 ` [PATCH 2/2] ethernet: arc: ARC_EMAC and EMAC_ROCKCHIP " Geert Uytterhoeven
2015-04-23 18:10   ` David Miller
2015-04-23 18:10 ` [PATCH 1/2] ethernet: amd: AMD_XGBE " David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).