From: Florian Westphal <fw@strlen.de>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>,
Cong Wang <cwang@twopensource.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
John Fastabend <john.r.fastabend@intel.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [RFC 2/3] tc: deprecate TC_ACT_QUEUED
Date: Thu, 23 Apr 2015 23:20:42 +0200 [thread overview]
Message-ID: <20150423212042.GA1627@breakpoint.cc> (raw)
In-Reply-To: <553959E3.9070209@mojatatu.com>
Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> 2) the ACT_QUEUED vs STOLEN was supposed to have semantics of something
> that was stolen (eg redirection should definetely have been returning
> STOLEN not QUEUED); something that queues for later re-injection
> (with any/all metadata) was intended to use QUEUED. I believe netfilter
> may have followed suit and introduced similar codes (so it would be
> interesting to see how they use them).
Hooks (Targets) don't queue themselves, i.e. NF_QUEUE tells the
netfilter core that the skb is to be handed off to nf_queue machinery,
while NF_STOLEN is the more obvious "don't touch this skb ever again".
next prev parent reply other threads:[~2015-04-23 21:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 19:27 [RFC 0/3] tc cleanup? Alexei Starovoitov
2015-04-21 19:27 ` [RFC 1/3] tc: fix return values of ingress qdisc Alexei Starovoitov
2015-04-22 4:59 ` Cong Wang
2015-04-22 22:04 ` Alexei Starovoitov
2015-04-22 23:29 ` Cong Wang
2015-04-23 8:46 ` Thomas Graf
2015-04-21 19:27 ` [RFC 2/3] tc: deprecate TC_ACT_QUEUED Alexei Starovoitov
2015-04-22 5:02 ` Cong Wang
2015-04-22 7:43 ` Daniel Borkmann
2015-04-22 22:22 ` Alexei Starovoitov
2015-04-22 23:39 ` Cong Wang
2015-04-23 2:46 ` Alexei Starovoitov
2015-04-23 7:13 ` Daniel Borkmann
2015-04-23 18:12 ` Cong Wang
2015-04-23 18:21 ` Daniel Borkmann
2015-04-23 18:30 ` Cong Wang
2015-04-23 20:45 ` Jamal Hadi Salim
2015-04-23 21:20 ` Florian Westphal [this message]
2015-04-23 22:13 ` Alexei Starovoitov
2015-04-23 22:33 ` Cong Wang
2015-04-23 22:51 ` Jamal Hadi Salim
2015-04-24 0:59 ` Alexei Starovoitov
2015-04-24 3:37 ` Cong Wang
2015-04-24 8:12 ` Daniel Borkmann
2015-04-27 12:31 ` Jamal Hadi Salim
2015-04-21 19:27 ` [RFC 3/3] tc: cleanup tc_classify Alexei Starovoitov
2015-04-22 5:05 ` Cong Wang
2015-04-22 22:27 ` Alexei Starovoitov
2015-04-22 23:38 ` Cong Wang
2015-04-23 8:49 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423212042.GA1627@breakpoint.cc \
--to=fw@strlen.de \
--cc=ast@plumgrid.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).