From: Michael Grzeschik <mgr@pengutronix.de>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros
Date: Mon, 27 Apr 2015 16:13:39 +0200 [thread overview]
Message-ID: <20150427141339.GB23151@pengutronix.de> (raw)
In-Reply-To: <1429916685.23327.32.camel@perches.com>
On Fri, Apr 24, 2015 at 04:04:45PM -0700, Joe Perches wrote:
> On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote:
> > The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK
> > and ADIAGSTATUS are unnecessary indirections to the use of registers.
> > This patch removes them and improves the readability of the code.
>
> This breaks compilation.
>
> Please compile test your patches before sending them.
Sorry, but I can not reproduce this break.
What was your base you applied this series on?
Can you send me the failure you get?
Thanks,
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2015-04-27 14:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 17:20 [PATCH 00/21] ARCNET: Defibrillation Michael Grzeschik
2015-04-24 17:20 ` [PATCH 01/21] com20020-pci: add dev_port for udev handling Michael Grzeschik
2015-04-24 17:20 ` [PATCH 02/21] ARCNET: fix hard_header_len limit Michael Grzeschik
2015-04-24 17:20 ` [PATCH 03/21] ARCNET: capmode: fix transfer length Michael Grzeschik
2015-04-24 17:20 ` [PATCH 04/21] ARCNET: whitespace, tab and codingstyle fixes Michael Grzeschik
2015-04-24 17:20 ` [PATCH 05/21] ARCNET: remove unneeded macros Michael Grzeschik
2015-04-24 17:20 ` [PATCH 06/21] ARCNET: com20020: " Michael Grzeschik
2015-04-24 23:04 ` Joe Perches
2015-04-25 3:59 ` David Miller
2015-04-27 14:13 ` Michael Grzeschik [this message]
2015-04-24 17:20 ` [PATCH 07/21] ARCNET: rimi: " Michael Grzeschik
2015-04-24 17:20 ` [PATCH 08/21] ARCNET: com90io: " Michael Grzeschik
2015-04-24 17:20 ` [PATCH 09/21] ARCNET: com90xx: " Michael Grzeschik
2015-04-24 17:20 ` [PATCH 10/21] ARCNET: com20020: fix ioaddr prefixes Michael Grzeschik
2015-04-24 17:20 ` [PATCH 11/21] ARCNET: rimi: " Michael Grzeschik
2015-04-24 17:20 ` [PATCH 12/21] ARCNET: com90io: " Michael Grzeschik
2015-04-24 17:20 ` [PATCH 13/21] ARCNET: com90xx: " Michael Grzeschik
2015-04-24 17:20 ` [PATCH 14/21] ARCNET: arc-rawmode: reorder module functions Michael Grzeschik
2015-04-24 17:20 ` [PATCH 15/21] ARCNET: capmode: remove extra function and use C99 in struct Michael Grzeschik
2015-04-24 17:20 ` [PATCH 16/21] ARCNET: capmode: move dev_free_skb to its only user Michael Grzeschik
2015-04-24 17:20 ` [PATCH 17/21] ARCNET: com20020: replace magic numbers with readable macros Michael Grzeschik
2015-04-24 17:20 ` [PATCH 18/21] ARCNET: com20020: remove obsolete BUS_ALIGN offset factor Michael Grzeschik
2015-04-24 17:20 ` [PATCH 19/21] ARCNET: com20020: add enable and disable device on open/close Michael Grzeschik
2015-04-24 17:20 ` [PATCH 20/21] ARCNET: com20020-pci: reformat structs to C99 format Michael Grzeschik
2015-04-24 17:20 ` [PATCH 21/21] ARCNET: com20020-pci: add rotary index support Michael Grzeschik
2015-04-24 18:47 ` [PATCH 00/21] ARCNET: Defibrillation Joe Perches
2015-04-24 21:14 ` Marc Kleine-Budde
2015-04-25 3:58 ` David Miller
2015-04-25 4:52 ` Joe Perches
2015-04-27 14:57 ` Michael Grzeschik
2015-04-30 3:49 ` Joe Perches
2015-05-05 16:43 ` Michael Grzeschik
2015-05-05 17:02 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150427141339.GB23151@pengutronix.de \
--to=mgr@pengutronix.de \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).