From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwl4965: Enable checking of format strings
Date: Tue, 28 Apr 2015 19:49:31 +0200 [thread overview]
Message-ID: <20150428174929.GA8397@redhat.com> (raw)
In-Reply-To: <877fsw5iq1.fsf@kamboji.qca.qualcomm.com>
On Tue, Apr 28, 2015 at 07:19:02PM +0300, Kalle Valo wrote:
> Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:
>
> > Since these fmt_* variables are just const char*, and not const
> > char[], gcc (and smatch) doesn't to type checking of the arguments to
> > the printf functions. Since the linker knows perfectly well to merge
> > identical string constants, there's no point in having three static
> > pointers waste memory and give an extra level of indirection.
> >
> > This removes over 100 "non-constant format argument" warnings from
> > smatch, accounting for about 20% of all such warnings in an
> > allmodconfig.
> >
> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>
> So what's the conclusion, should I commit this patch or not?
>
> Full discussion here:
>
> https://patchwork.kernel.org/patch/5814811/
I do not see the point of the patch. If compiler behave not
optimally, fix the compiler. NACK.
Stanislaw
prev parent reply other threads:[~2015-04-28 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 22:51 [PATCH] iwl4965: Enable checking of format strings Rasmus Villemoes
2015-02-12 0:41 ` Rustad, Mark D
2015-02-12 10:20 ` Rasmus Villemoes
2015-02-13 7:55 ` Mark Rustad
2015-02-13 10:39 ` Rasmus Villemoes
2015-02-13 11:20 ` David Laight
2015-02-13 12:04 ` Rasmus Villemoes
[not found] ` <1423695069-23436-1-git-send-email-linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
2015-04-28 16:19 ` Kalle Valo
2015-04-28 17:49 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428174929.GA8397@redhat.com \
--to=sgruszka@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).