From: Felix Janda <felix.janda@posteo.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] Use PATH_MAX instead of MAXPATHLEN
Date: Wed, 29 Apr 2015 18:52:05 +0200 [thread overview]
Message-ID: <20150429165205.GA1364@euler> (raw)
In-Reply-To: <55400DE7.9080501@gmail.com>
Florian Fainelli wrote:
> On 27/04/15 09:13, Stephen Hemminger wrote:
> > On Sat, 25 Apr 2015 22:33:28 +0200
> > Felix Janda <felix.janda@posteo.de> wrote:
> >
> >> They are equivalent but the former is more common. PATH_MAX is
> >> specified by POSIX and needs <limits.h> while MAXPATHLEN has BSD
> >> origin and needs <sys/param.h>.
> >>
> >> PATH_MAX has already been in use in misc/lnstat.h.
> >>
> >> Signed-off-by: Felix Janda <felix.janda@posteo.de>
> >
> > Iproute2 is intended for use on Linux.
> > It makes more sense to align with Posix than using leftover
> > BSD stuff. Therefore I don't see any point in doing this.
>
> My reading from Felix's commit message is that he is attempting to do
> exactly that: conform to POSIX rather than BSD, which seems to be the
> direction you are also suggesting here.
> --
> Florian
This is correct. (In fact I misread the end of Stephen's message,
thought that the patch was merged and wanted to thank for that.)
Felix
next prev parent reply other threads:[~2015-04-29 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 20:33 [PATCH iproute2] Use PATH_MAX instead of MAXPATHLEN Felix Janda
2015-04-27 16:13 ` Stephen Hemminger
2015-04-28 22:47 ` Florian Fainelli
2015-04-29 16:52 ` Felix Janda [this message]
2015-07-21 20:40 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429165205.GA1364@euler \
--to=felix.janda@posteo.de \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).