From: David Miller <davem@davemloft.net>
To: Yuval.Mintz@qlogic.com
Cc: krisman@linux.vnet.ibm.com, LinoSanfilippo@gmx.de,
Ariel.Elior@qlogic.com, netdev@vger.kernel.org,
cascardo@linux.vnet.ibm.com, cascardo@cascardo.eti.br,
brking@linux.vnet.ibm.com
Subject: Re: [PATCH v2] bnx2x: Alloc 4k fragment for each rx ring buffer element
Date: Thu, 30 Apr 2015 16:05:37 -0400 (EDT) [thread overview]
Message-ID: <20150430.160537.232956261880122754.davem@davemloft.net> (raw)
In-Reply-To: <B5657A6538887040AD3A81F1008BEC63D383CB@avmb3.qlogic.org>
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Thu, 30 Apr 2015 11:25:31 +0000
>> +struct bnx2x_alloc_pool {
>> + struct page *page;
>> + dma_addr_t dma;
>> + int len;
>
> Isn't len always set to PAGE_SIZE? If so it can be dropped
Agreed, len appears unnecessary.
next prev parent reply other threads:[~2015-04-30 20:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 20:45 [PATCH v2] bnx2x: Alloc 4k fragment for each rx ring buffer element Gabriel Krisman Bertazi
2015-04-24 23:24 ` Lino Sanfilippo
2015-04-29 13:30 ` Gabriel Krisman Bertazi
2015-04-30 11:25 ` Yuval Mintz
2015-04-30 20:05 ` David Miller [this message]
2015-05-04 19:32 ` [PATCH v3] " Gabriel Krisman Bertazi
2015-05-04 19:58 ` Yuval Mintz
2015-05-15 20:43 ` Gabriel Krisman Bertazi
2015-05-17 7:14 ` Yuval Mintz
2015-05-21 13:20 ` [PATCH v4] " Gabriel Krisman Bertazi
2015-05-23 10:04 ` Yuval Mintz
2015-05-23 11:14 ` Lino Sanfilippo
2015-05-27 8:59 ` Michal Schmidt
2015-05-27 16:51 ` [PATCH] " Gabriel Krisman Bertazi
2015-06-01 22:57 ` David Miller
2015-05-28 7:24 ` [PATCH v4] " Yuval Mintz
2015-05-28 13:26 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430.160537.232956261880122754.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@qlogic.com \
--cc=LinoSanfilippo@gmx.de \
--cc=Yuval.Mintz@qlogic.com \
--cc=brking@linux.vnet.ibm.com \
--cc=cascardo@cascardo.eti.br \
--cc=cascardo@linux.vnet.ibm.com \
--cc=krisman@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).