Re: [PATCH 6/6] net: move qdisc ingress filtering on top of netfilter ingress hooks

Daniel Borkmann
2015-04-30T09:24:57Z

On 04/30/2015 08:02 AM, Alexei Starovoitov wrote:
...
> My point is that I agree that cleanup of ingress qdisc is needed.
> I disagree with drastic measures.
> Just add your nf_hook to ingress and let's see how things evolve.
> We have rx_handler and all of ptype hooks in there. One can argue
> that rx_handler overlaps with nf_hook too ? ;)
> We cannot generalize them all under one 'hook' infra.
> nf needs to do nf_hook_state_init() and pass it around which
> no one else needs. That's the cost others should not pay.

+1