Re: [PATCH 6/6] net: move qdisc ingress filtering on top of netfilter ingress hooks

Cong Wang
2015-04-29T21:53:58Z

On Wed, Apr 29, 2015 at 11:53 AM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> diff --git a/net/sched/Kconfig b/net/sched/Kconfig
> index 2274e72..23b57da 100644
> --- a/net/sched/Kconfig
> +++ b/net/sched/Kconfig
> @@ -312,6 +312,7 @@ config NET_SCH_PIE
> config NET_SCH_INGRESS
> tristate "Ingress Qdisc"
> depends on NET_CLS_ACT
> + select NETFILTER_INGRESS
> ---help---
> Say Y here if you want to use classifiers for incoming packets.
> If unsure, say Y.

So now it impossible to compile ingress Qdics without netfilters...

(I know you moved them into net/core/, but still they are netfilter API's.)

Why do we have to mix different layers? IOW, why not just keep TC at L2
and netfilters at L3 even just w.r.t. API?