Re: [PATCH 4/6] netfilter: move generic hook infrastructure into net/core/hooks.c

Patrick McHardy
2015-04-29T23:59:32Z

On 29.04, Pablo Neira Ayuso wrote:
> This patch moves the very basic hook infrastructure into net/core/hooks.c
> and it also adds a new CONFIG_NETFILTER_HOOKS kconfig switch.
>
> The idea is to allow CONFIG_NETFILTER_HOOKS selection from qdisc ingress
> without depending on the full Netfilter layer 3 hooks (ie. CONFIG_NETFILTER).
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> MAINTAINERS | 1 +
> include/linux/netfilter.h | 96 +----------------------
> include/linux/netfilter_hooks.h | 117 ++++++++++++++++++++++++++++
> include/net/netfilter/nf_queue.h | 1 +
> net/Kconfig | 7 ++
> net/core/Makefile | 1 +
> net/core/dev.c | 2 +
> net/core/hooks.c | 159 ++++++++++++++++++++++++++++++++++++++
> net/netfilter/core.c | 149 +----------------------------------
> net/netfilter/nf_internals.h | 2 -

Just a general comment, still reviewing in detail, but it would be preferrable
to have a diff using -M -C to have the rename seen in the diff itself.

Cheers,
Patrick