Re: [PATCH 0/3] A few minor clean-ups to eth_type_trans

[Alexei Starovoitov <alexei.starovoitov@gmail.com>]

On Thu, Apr 30, 2015 at 02:53:42PM -0700, Alexander Duyck wrote:
> This series addresses a few minor issues I found in eth_type_trans that
> that allow us to gain back something like 3 or more cycles per packet.  
> 
> The first change is to drop the byte swap since it isn't necessary.  On x86
> we could just check the first byte and compare that against the upper 8
> bits of the Ethertype to determine if we are dealing with a size value or
> not.
> 
> The second makes it so that the value we read in to test for multicast can
> be used for the address comparison.  This allows us to avoid a second read
> of the destination address.
> 
> The final change is to avoid some unneeded instructions in computing the
> Ethernet header pointer.  When we start the call the Ethernet header is at
> skb->data, so we just use that rather than computing mac_header, and then
> adding that back to skb->head.

Great stuff! Excellent optimizations.

Only the comment 'ETH_P_802_3_MIN is aligned to 512' through me off.
It's divisible by 256 that matters.