Netdev List
 help / color / mirror / Atom feed
From: Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com>
To: <netdev@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Eric Dumazet <edumazet@google.com>,
	Tom Herbert <therbert@google.com>,
	Vlad Yasevich <vyasevic@redhat.com>,
	Jiri Pirko <jiri@resnulli.us>,
	John Fastabend <john.fastabend@gmail.com>,
	Joe Perches <joe@perches.com>
Subject: [RFC] NAPI behavior when (work < weight)
Date: Wed, 4 Feb 2015 15:22:38 +0200	[thread overview]
Message-ID: <2015045.8auvsRvBkK@lx-wigig-72> (raw)

Hi

I am observing that if driver does not calls napi_complete() when
less than full budget consumed, various strange things happen.

For example, if driver going to napi_disable(), it may wait forever
in the loop:

	while (test_and_set_bit(NAPI_STATE_SCHED, &n->state))
		msleep(1);

if last NAPI consumed less then full budget, because bit
NAPI_STATE_SCHED never cleared.

Is it expected that driver calls napi_complete() when less than full
budget consumed? Documentation does not say so.

What is intended behavior in case above?

Thanks, Vladimir 

             reply	other threads:[~2015-02-04 13:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 13:22 Vladimir Kondratiev [this message]
2015-02-04 13:37 ` [RFC] NAPI behavior when (work < weight) Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2015045.8auvsRvBkK@lx-wigig-72 \
    --to=qca_vkondrat@qca.qualcomm.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jiri@resnulli.us \
    --cc=joe@perches.com \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox