From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH net-next 2/2] rhashtable: Quick initial growth of tables
Date: Fri, 1 May 2015 06:30:25 +0200 [thread overview]
Message-ID: <20150501043025.GB26676@pox.localdomain> (raw)
In-Reply-To: <20150430234556.GA31180@gondor.apana.org.au>
On 05/01/15 at 07:45am, Herbert Xu wrote:
> Thomas Graf <tgraf@suug.ch> wrote:
> > Grow the table quicker than 2x in the beginning to avoid long chains
> > of rehashes. The effect is observable in the self-test where table
> > jumps are reduced to a minimum after a lot of entries have been added
> > in a short period of time. The iterator is able to get a consistent
> > view most of the time.
> >
> > Signed-off-by: Thomas Graf <tgraf@suug.ch>
>
> Wouldn't automatic shrinking immediately undo your quick growth?
Yes, that can happen. Since shrinks are ordered to the end of the
chain it is often the case that enough entries have been added so the
shrink is not carried out in the end. Obviously this is also not the
case if no entries are actually removed.
What about we apply quick growing on >100% utilization? It is a
clear indication that we are growing rapidly.
next prev parent reply other threads:[~2015-05-01 4:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 22:46 [PATCH net-next 0/2] rhashtable: Quick initial table growth Thomas Graf
2015-04-30 22:46 ` [PATCH net-next 1/2] rhashtable: Simplify iterator code Thomas Graf
2015-04-30 23:41 ` Herbert Xu
2015-04-30 22:46 ` [PATCH net-next 2/2] rhashtable: Quick initial growth of tables Thomas Graf
2015-04-30 23:45 ` Herbert Xu
2015-05-01 4:30 ` Thomas Graf [this message]
2015-05-01 4:37 ` Herbert Xu
2015-05-01 13:38 ` Thomas Graf
2015-05-01 11:04 ` Sergei Shtylyov
2015-05-01 13:38 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501043025.GB26676@pox.localdomain \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox