From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: brouer@redhat.com, Alexei Starovoitov <ast@plumgrid.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Robert Olsson <robert@herjulf.net>,
Ben Greear <greearb@candelatech.com>
Subject: Re: [PATCH v3 net-next] pktgen: introduce 'rx' mode
Date: Sat, 2 May 2015 11:54:43 +0200 [thread overview]
Message-ID: <20150502115443.2f89736e@redhat.com> (raw)
In-Reply-To: <55449C8D.4020902@iogearbox.net>
On Sat, 02 May 2015 11:44:45 +0200
Daniel Borkmann <daniel@iogearbox.net> wrote:
> Hi Jesper,
>
> On 05/02/2015 10:46 AM, Jesper Dangaard Brouer wrote:
> ...
> > First of all I love the idea of modifying pktgen to performance test
> > the RX path.
> >
> > I'm not sure the simple "rx" flag is a good "name". It likely
> > conflicts with other work where pktgen can receive it own packets, e.g.
> > https://people.kth.se/~danieltt/pktgen/ or Ben Greer's solution.
>
> Why do we start caring about out of tree code now? We never have,
> really. If there is no interest in merging this stuff upstream,
> then it's always the case that _their code_ needs to adapt iff you
> want to run on a more recent kernel; the kernel dictates the uapi,
> not some out of tree module. ;)
Sure, out-of-tree code should not control our choices.
I personally just don't like the "RX" flag name.
What about "STACK_RX" or "RX_INJECT"?
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2015-05-02 9:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 5:12 [PATCH v3 net-next] pktgen: introduce 'rx' mode Alexei Starovoitov
2015-05-01 16:54 ` Eric Dumazet
2015-05-02 8:46 ` Jesper Dangaard Brouer
2015-05-02 9:44 ` Daniel Borkmann
2015-05-02 9:54 ` Jesper Dangaard Brouer [this message]
2015-05-02 10:30 ` Daniel Borkmann
2015-05-02 16:01 ` Alexei Starovoitov
2015-05-02 16:46 ` Jesper Dangaard Brouer
2015-05-02 17:07 ` Alexei Starovoitov
2015-05-05 18:15 ` Jesper Dangaard Brouer
2015-05-05 18:30 ` Alexei Starovoitov
2015-05-05 20:29 ` [PATCH 0/2] pktgen changes Jesper Dangaard Brouer
2015-05-05 20:29 ` [PATCH 1/2] pktgen: adjust flag NO_TIMESTAMP to be more pktgen compliant Jesper Dangaard Brouer
2015-05-05 20:30 ` [PATCH 2/2] pktgen: introduce xmit_mode 'rx_inject' Jesper Dangaard Brouer
2015-05-06 4:33 ` Alexei Starovoitov
2015-05-06 5:24 ` Jesper Dangaard Brouer
2015-05-06 10:17 ` Daniel Borkmann
2015-05-06 11:22 ` Jesper Dangaard Brouer
2015-05-06 5:32 ` Alexander Duyck
2015-05-06 8:44 ` Jesper Dangaard Brouer
2015-05-06 14:35 ` Alexei Starovoitov
2015-05-07 14:34 ` [PATCH v5 0/2] pktgen changes Jesper Dangaard Brouer
2015-05-07 14:34 ` [PATCH v5 1/2] pktgen: adjust flag NO_TIMESTAMP to be more pktgen compliant Jesper Dangaard Brouer
2015-05-07 14:35 ` [PATCH v5 2/2] pktgen: introduce xmit_mode '<start_xmit|netif_receive>' Jesper Dangaard Brouer
2015-05-07 16:28 ` Alexei Starovoitov
2015-05-07 17:11 ` Daniel Borkmann
2015-05-07 17:16 ` Alexei Starovoitov
2015-05-07 17:20 ` Daniel Borkmann
2015-05-08 13:40 ` Multiqueue pktgen (was: [PATCH v5 2/2] pktgen: introduce xmit_mode '<start_xmit|netif_receive>') Jesper Dangaard Brouer
2015-05-08 15:39 ` [PATCH v5 2/2] pktgen: introduce xmit_mode '<start_xmit|netif_receive>' Jesper Dangaard Brouer
2015-05-08 15:49 ` Multiqueue pktgen and ingress path (Was: [PATCH v5 2/2] pktgen: introduce xmit_mode '<start_xmit|netif_receive>') Jesper Dangaard Brouer
2015-05-08 15:56 ` Eric Dumazet
2015-05-08 16:53 ` Alexander Duyck
2015-05-08 17:00 ` Alexei Starovoitov
2015-05-08 18:21 ` Alexander Duyck
2015-05-08 15:57 ` [PATCH v5 2/2] pktgen: introduce xmit_mode '<start_xmit|netif_receive>' Eric Dumazet
2015-05-08 16:50 ` Alexei Starovoitov
2015-05-10 2:26 ` [PATCH v5 0/2] pktgen changes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150502115443.2f89736e@redhat.com \
--to=brouer@redhat.com \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=robert@herjulf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).