From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: brouer@redhat.com, "David S. Miller" <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next] tc: remove unused redirect ttl
Date: Sun, 3 May 2015 17:28:42 +0200 [thread overview]
Message-ID: <20150503172842.42379466@redhat.com> (raw)
In-Reply-To: <1430543983-10446-1-git-send-email-ast@plumgrid.com>
On Fri, 1 May 2015 22:19:43 -0700
Alexei Starovoitov <ast@plumgrid.com> wrote:
> From: Jamal Hadi Salim <jhs@mojatatu.com>
>
> improves ingress+u32 performance from 22.4 Mpps to 22.9 Mpps
I like this change and I'm ACKing it.
But I would like to comment on these performance numbers. I assume this
is a single CPU test with your pktgen RX/STACK_INJECT mode that drops
the packet "early (in ip_rcv() I think).
It sound impressive to get +0.5 Mpps improvement from such a small
change, while in reality this is approx a 1ns improvement.
(1/(22.4*10^6)*10^9) = 44.64ns
(1/(22.9*10^6)*10^9) = 43.67ns
improvement diff = 0.97ns
I'm a fan of zooming in on parts of the stack, as it allow us to
performance optimize and measure parts of the stack that is normally
hard to measure. And your ingress use-case is valid. People should
just be aware, that we can easily "over-sell" when "zooming" in...
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
> Acked-by: Florian Westphal <fw@strlen.de>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2015-05-03 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 5:19 [PATCH v3 net-next] tc: remove unused redirect ttl Alexei Starovoitov
2015-05-03 15:28 ` Jesper Dangaard Brouer [this message]
2015-05-04 4:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150503172842.42379466@redhat.com \
--to=brouer@redhat.com \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).