* [PATCH net-next] sock: fix comment location
@ 2015-05-03 20:55 Jεan Sacren
2015-05-03 21:05 ` Florian Westphal
0 siblings, 1 reply; 3+ messages in thread
From: Jεan Sacren @ 2015-05-03 20:55 UTC (permalink / raw)
To: netdev; +Cc: Eric Dumazet
From: Jean Sacren <sakiwit@gmail.com>
The block of comment is for 'sk_incoming_cpu' rather than 'sk_txhash'.
Therefore, move it above "u16 sk_incoming_cpu;" where it belongs.
Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
---
include/net/sock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/sock.h b/include/net/sock.h
index 3a4898ec8c67..42a8670e5baf 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -352,11 +352,11 @@ struct sock {
#ifdef CONFIG_RPS
__u32 sk_rxhash;
#endif
- u16 sk_incoming_cpu;
/* 16bit hole
* Warned : sk_incoming_cpu can be set from softirq,
* Do not use this hole without fully understanding possible issues.
*/
+ u16 sk_incoming_cpu;
__u32 sk_txhash;
#ifdef CONFIG_NET_RX_BUSY_POLL
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sock: fix comment location
2015-05-03 20:55 [PATCH net-next] sock: fix comment location Jεan Sacren
@ 2015-05-03 21:05 ` Florian Westphal
2015-05-03 21:11 ` Jεan Sacren
0 siblings, 1 reply; 3+ messages in thread
From: Florian Westphal @ 2015-05-03 21:05 UTC (permalink / raw)
To: Jεan Sacren; +Cc: netdev, Eric Dumazet
Jεan Sacren <sakiwit@gmail.com> wrote:
> From: Jean Sacren <sakiwit@gmail.com>
>
> The block of comment is for 'sk_incoming_cpu' rather than 'sk_txhash'.
> Therefore, move it above "u16 sk_incoming_cpu;" where it belongs.
comment is at the right place.
> diff --git a/include/net/sock.h b/include/net/sock.h
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> - u16 sk_incoming_cpu;
> /* 16bit hole
> * Warned : sk_incoming_cpu can be set from softirq,
> * Do not use this hole without fully understanding possible issues.
> */
> + u16 sk_incoming_cpu;
This hole is between sk_incoming_cpu and sk_txhash.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sock: fix comment location
2015-05-03 21:05 ` Florian Westphal
@ 2015-05-03 21:11 ` Jεan Sacren
0 siblings, 0 replies; 3+ messages in thread
From: Jεan Sacren @ 2015-05-03 21:11 UTC (permalink / raw)
To: Florian Westphal; +Cc: netdev, Eric Dumazet
From: Florian Westphal <fw@strlen.de>
Date: Sun, 03 May 2015 23:05:34 +0200
>
> Jεan Sacren <sakiwit@gmail.com> wrote:
> > From: Jean Sacren <sakiwit@gmail.com>
> >
> > The block of comment is for 'sk_incoming_cpu' rather than 'sk_txhash'.
> > Therefore, move it above "u16 sk_incoming_cpu;" where it belongs.
>
> comment is at the right place.
>
> > diff --git a/include/net/sock.h b/include/net/sock.h
> > --- a/include/net/sock.h
> > +++ b/include/net/sock.h
> > - u16 sk_incoming_cpu;
> > /* 16bit hole
> > * Warned : sk_incoming_cpu can be set from softirq,
> > * Do not use this hole without fully understanding possible issues.
> > */
> > + u16 sk_incoming_cpu;
>
> This hole is between sk_incoming_cpu and sk_txhash.
I'm so sorry. Thank you for teaching me. I did wish there were an empty
line below "u16 sk_incoming_cpu;"
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-03 21:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-03 20:55 [PATCH net-next] sock: fix comment location Jεan Sacren
2015-05-03 21:05 ` Florian Westphal
2015-05-03 21:11 ` Jεan Sacren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).