From: Martin KaFai Lau <kafai@fb.com>
To: netdev <netdev@vger.kernel.org>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
Julian Anastasov <ja@ssi.bg>, David Miller <davem@davemloft.net>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [RFC PATCH net-next v3 3/9] ipv6: Combine rt6_alloc_cow and rt6_alloc_clone
Date: Mon, 4 May 2015 10:08:27 -0700 [thread overview]
Message-ID: <20150504170826.GH2731450@devbig242.prn2.facebook.com> (raw)
In-Reply-To: <1430526418-3132761-4-git-send-email-kafai@fb.com>
On Fri, May 01, 2015 at 05:26:52PM -0700, Martin KaFai Lau wrote:
> static struct rt6_info *ip6_pol_route(struct net *net, struct fib6_table *table, int oif,
> struct flowi6 *fl6, int flags)
> {
> @@ -918,10 +914,9 @@ redo_rt6_select:
> if (rt->rt6i_flags & RTF_CACHE)
> goto out2;
>
> - if (!(rt->rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY)))
> - nrt = rt6_alloc_cow(rt, &fl6->daddr, &fl6->saddr);
> - else if (!(rt->dst.flags & DST_HOST) || !(rt->dst.flags & RTF_LOCAL))
> - nrt = rt6_alloc_clone(rt, &fl6->daddr);
> + if (!rt6_is_gw_or_nonexthop(rt) ||
> + !(rt->dst.flags & DST_HOST) || !(rt->dst.flags & RTF_LOCAL))
It inherited a similar typo here which has already been fixed in net-next.
rt->dst.flags instead of rt->rt6i_flags is used when checking the RTF_LOCAL
flag. The other patches are still good for review purpose. I will re-post this
series later.
--Martin
next prev parent reply other threads:[~2015-05-04 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 0:26 [RFC PATCH net-next v3 0/9] ipv6: Only create RTF_CACHE route after encountering pmtu exception Martin KaFai Lau
2015-05-02 0:26 ` [RFC PATCH net-next v3 1/9] ipv6: Remove external dependency on rt6i_dst and rt6i_src Martin KaFai Lau
2015-05-02 0:26 ` [RFC PATCH net-next v3 2/9] ipv6: Remove external dependency on rt6i_gateway and RTF_ANYCAST Martin KaFai Lau
2015-05-02 0:26 ` [RFC PATCH net-next v3 3/9] ipv6: Combine rt6_alloc_cow and rt6_alloc_clone Martin KaFai Lau
2015-05-04 17:08 ` Martin KaFai Lau [this message]
2015-05-02 0:26 ` [RFC PATCH net-next v3 4/9] ipv6: Only create RTF_CACHE routes after encountering pmtu exception Martin KaFai Lau
2015-05-02 0:26 ` [RFC PATCH net-next v3 5/9] ipv6: Add rt6_get_cookie() function Martin KaFai Lau
2015-05-02 0:26 ` [RFC PATCH net-next v3 6/9] ipv6: Set FLOWI_FLAG_KNOWN_NH at flowi6_flags Martin KaFai Lau
2015-05-02 12:21 ` Julian Anastasov
2015-05-02 0:26 ` [RFC PATCH net-next v3 7/9] ipv6: Create RTF_CACHE clone when FLOWI_FLAG_KNOWN_NH is set Martin KaFai Lau
2015-05-02 0:26 ` [RFC PATCH net-next v3 8/9] ipv6: Break up ip6_rt_copy() Martin KaFai Lau
2015-05-02 0:26 ` [RFC PATCH net-next v3 9/9] ipv6: Create percpu rt6_info Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150504170826.GH2731450@devbig242.prn2.facebook.com \
--to=kafai@fb.com \
--cc=Kernel-team@fb.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).